Re: [PATCH v8 1/2] dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The schema lacks a conditional constraint to restrict `port@1` for the 1-port LT9611C variant, and the title incorrectly describes all devices as 2-port.
- [Low] Use of Chinese ideographic commas instead of standard ASCII commas in the description.
--

--- Patch [1]: [PATCH v8 1/2] dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver ---
commit 479e58120e4ea7ccc6ba2a2452966c2bdee319fa
Author: Sunyun Yang <syyang@lontium.com>

dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver

This commit adds compatible strings and documentation for the Lontium LT9611C,
LT9611EX, and LT9611UXD MIPI DSI to HDMI bridges.

> diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> index 429a06057ae85..e0821a63d9d74 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> @@ -4,19 +4,23 @@
>  $id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Lontium LT9611(UXC) 2 Port MIPI to HDMI Bridge
> +title: Lontium LT9611(UXC/C/EX/UXD) 2 Port MIPI DSI to HDMI Bridge

[Severity: Medium]
The commit message notes that the LT9611C variant supports 1-port MIPI DSI.
Does this title need to be adjusted since it broadly describes all of the
supported devices as "2 Port"?

>  maintainers:
>    - Vinod Koul <vkoul@kernel.org>
>  
>  description: |
> -  The LT9611 and LT9611UXC are bridge devices which convert DSI to HDMI
> +  The LT9611、LT9611UXC、LT9611C、LT9611EX and LT9611UXD

[Severity: Low]
This isn't a bug, but there appear to be non-ascii ideographic commas
used in this list instead of standard commas. Should these be replaced to
prevent rendering or text-processing quirks in the documentation?

> +  are bridge devices which convert DSI to HDMI
>  
>  properties:
>    compatible:
>      enum:
>        - lontium,lt9611
> +      - lontium,lt9611c

[Severity: Medium]
Since the LT9611C variant only supports a single MIPI DSI port, should the
schema include an allOf: conditional block to explicitly set port@1: false
for the lontium,lt9611c compatible string?

Without this constraint, device tree configurations that accidentally include
an invalid second DSI port (port@1) will silently pass schema validation
for this hardware variant.

> +      - lontium,lt9611ex
>        - lontium,lt9611uxc
> +      - lontium,lt9611uxd

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728-lt9611c-v7-v8-0-bda216bfaf37@oss.qualcomm.com?part=1