Re: [PATCH 5/6] arm64: dts: qcom: lemans: Add support for TSCSS node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Devicetree compatible string for the TSCSS node uses the internal SoC codename 'lemans' rather than the official part number 'sa8775p'.
--

--- Patch [5]: [PATCH 5/6] arm64: dts: qcom: lemans: Add support for TSCSS node ---
commit 534c460b6703617b947d74b06656ce6dd2f6d6c4
Author: Imran Shaik <imran.shaik@oss.qualcomm.com>

arm64: dts: qcom: lemans: Add support for TSCSS node

This commit adds Timestamp Counter Subsystem (TSCSS) node support on
Qualcomm Lemans SoCs.

> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
[ ... ]
> @@ -3023,6 +3023,17 @@ pcie1_phy: phy@1c14000 {
>  			status = "disabled";
>  		};
>  
> +		tscss@1c80000 {
> +			compatible = "qcom,lemans-tscss";

[Severity: Low]
This isn't a bug, but would it be better to use the official commercial part
number "qcom,sa8775p-tscss" for this compatible string rather than the internal
SoC codename "lemans"?

Other IP blocks in this file appear to use the "qcom,sa8775p-*" pattern.
For example, the UFS host controller just below this node uses
"qcom,sa8775p-ufshc". Staying consistent with the part number helps maintain
the Devicetree ABI standards.

> +			reg = <0x0 0x01c80000 0x0 0x2000>;
> +			reg-names = "tsc";
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-tscss-v1-0-beed14e72510@oss.qualcomm.com?part=5