Re: [PATCH 7/8] arm64: dts: qcom: x1p42100-crd: Add qcom,tsens for EC fan thermal management

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `embedded-controller@76` node is instantiated in `x1p42100-crd.dts` without essential base properties (`compatible`, `reg`, `interrupts`), resulting in devicetree compiler warnings and driver binding failure.
--

--- Patch [7]: [PATCH 7/8] arm64: dts: qcom: x1p42100-crd: Add qcom,tsens for EC fan thermal management ---
commit 6a0028e3f0e9078f36aed5052ae5c17e337676ff
Author: Anvesh Jain P <anvesh.p@oss.qualcomm.com>

arm64: dts: qcom: x1p42100-crd: Add qcom,tsens for EC fan thermal management

This commit adds the qcom,tsens property to the embedded-controller node in
the x1p42100-crd device tree for fan thermal management.

> diff --git a/arch/arm64/boot/dts/qcom/x1p42100-crd.dts b/arch/arm64/boot/dts/qcom/x1p42100-crd.dts
> index 7ed4116b95904..b46b67c5e4366 100644
> --- a/arch/arm64/boot/dts/qcom/x1p42100-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/x1p42100-crd.dts

[ ... ]

> +&i2c5 {
> +	embedded-controller@76 {
> +		qcom,tsens = <&tsens2 11>;
> +	};
> +};

[Severity: High]
Does declaring the embedded-controller@76 node here create a new, incomplete
node?

Since this node isn't defined in the included base files, it appears to be
missing the required "compatible" and "reg" properties. Will this lead to a
devicetree compiler warning about a unit name without a reg property, and
prevent the qcom-hamoa-ec driver from binding?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com?part=7