Re: [PATCH v3 2/2] arm64: dts: qcom: Add support for Acer Swift Go Pro AI (SFA14-11)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Incorrect audio routing for the right speakers.
- [Medium] Missing `-el2-dtbs` build rule for the Acer Swift Go 14.
--

--- Patch [2]: [PATCH v3 2/2] arm64: dts: qcom: Add support for Acer Swift Go Pro AI (SFA14-11) ---
commit 7b73d33b3eeafdf356a13cef16dee5622aee6de8
Author: Kaipeng Zeng <kaipeng94@gmail.com>

arm64: dts: qcom: Add support for Acer Swift Go Pro AI (SFA14-11)

Introduce device tree for the Acer Swift Go Pro AI (SFA14-11), a laptop based
on the Qualcomm Snapdragon X Elite (X1E78100) SoC. This adds support for basic
peripherals including display, keyboard, touchpad, Wi-Fi, and audio.

> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -422,6 +422,7 @@ talos-evk-lvds-auo,g133han01-dtbs	:= \
>  dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk-lvds-auo,g133han01.dtb
>  x1e001de-devkit-el2-dtbs	:= x1e001de-devkit.dtb x1-el2.dtbo
>  dtb-$(CONFIG_ARCH_QCOM)	+= x1e001de-devkit.dtb x1e001de-devkit-el2.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= x1e78100-acer-sfa14-11.dtb

[Severity: Medium]
Are we missing the -el2.dtb combination rule for this board?

Snapdragon X Elite laptops usually rely on EL2 memory reservations to boot
successfully on stock firmware. Other devices in this Makefile include a rule
like x1e78100-acer-sfa14-11-el2-dtbs := x1e78100-acer-sfa14-11.dtb x1-el2.dtbo
to generate the required overlay.

Could this omission cause boot failures on the Acer Swift Go?

>  x1e78100-lenovo-thinkpad-t14s-el2-dtbs	:= x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
>  dtb-$(CONFIG_ARCH_QCOM)	+= x1e78100-lenovo-thinkpad-t14s.dtb x1e78100-lenovo-thinkpad-t14s-el2.dtb

> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts b/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts

[ ... ]

> +	sound {
> +		compatible = "qcom,x1e80100-sndcard";
> +		model = "X1E78100-ACER-Swift-Go-SFA14-11";
> +		audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT",
> +				"TweeterLeft IN", "WSA WSA_SPK2 OUT",
> +				"WooferRight IN", "WSA2 WSA_SPK2 OUT",
> +				"TweeterRight IN", "WSA2 WSA_SPK2 OUT",

[Severity: Medium]
Does this right channel routing mix the woofer and tweeter signals into the
same output?

It looks like "WooferRight IN" and "TweeterRight IN" are both routed to
"WSA2 WSA_SPK2 OUT", leaving "WSA2 WSA_SPK1 OUT" unconnected.

Should one of these be routed to WSA_SPK1 to match the frequency separation
done for the left speakers?

> +				"IN1_HPHL", "HPHL_OUT",
> +				"IN2_HPHR", "HPHR_OUT",
> +				"AMIC2", "MIC BIAS2",

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729064538.19564-1-kaipeng94@gmail.com?part=2