Re: [PATCH v2 1/2] dt-bindings: gpio: Add Axiado SGPIO controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Schema Validation Logic Bug: The `if` condition for `axiado,ax3000-sgpio` incorrectly uses `const` instead of `contains: const`.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: gpio: Add Axiado SGPIO controller ---
commit f6cc693f3d06f8cf16f8579009218084ca514b3e
Author: Petar Stepanovic <pstepanovic@axiado.com>

dt-bindings: gpio: Add Axiado SGPIO controller

This commit adds a Devicetree binding for the SGPIO controller found on the
Axiado AX3000 and AX3005 SoCs. The controller operates as a shift-based
interface to multiplex multiple GPIO signals over a small set of physical lines.

> diff --git a/Documentation/devicetree/bindings/gpio/axiado,sgpio.yaml b/Documentation/devicetree/bindings/gpio/axiado,sgpio.yaml
> new file mode 100644
> index 0000000000000..448f01c367dc1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/axiado,sgpio.yaml

[ ... ]

> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: axiado,ax3000-sgpio

[Severity: Medium]
Does this condition correctly match the compatible string?

Since the compatible property is evaluated as an array of strings in the
device tree, using const to match directly against a scalar string will always
evaluate to false. 

Because this condition always fails, it allows invalid device tree
configurations to silently pass validation since the ngpios constraint for the
axiado,ax3000-sgpio variant will not be enforced during a dt_binding_check.

Would it be better to use contains: const: axiado,ax3000-sgpio instead?

> +    then:
> +      properties:
> +        ngpios:
> +          const: 128

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729-axiado-ax3000-sgpio-controller-v2-0-976f4ed11438@axiado.com?part=1