Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rodrigo Alencar" <rodrigo.alencar@analog.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v10 07/17] iio: test: add kunit tests for channel prefix naming generation
Date: Wed, 29 Jul 2026 08:38:03 +0000	[thread overview]
Message-ID: <20260729083803.C211C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260729-ad9910-iio-driver-v10-7-aa1f6167729e@analog.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Kconfig help text incorrectly claims that the tests are compiled into the IIO core module.
--

--- Patch [7]: [PATCH v10 07/17] iio: test: add kunit tests for channel prefix naming generation ---
commit 1dfc71650388b9628c03d727921e09ce430c3fe7
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

iio: test: add kunit tests for channel prefix naming generation

This commit adds a KUnit test suite for the __iio_chan_prefix_emit() helper.
It exercises various channel prefix generation combinations including shared
modes, indexing, and error paths.

> diff --git a/drivers/iio/test/Kconfig b/drivers/iio/test/Kconfig
> index 4fc17dd0dcd77..7d2c29cc583b9 100644
> --- a/drivers/iio/test/Kconfig
> +++ b/drivers/iio/test/Kconfig
[ ... ]
> +config IIO_CHANNEL_PREFIX_KUNIT_TEST
> +	tristate "Test IIO channel prefix" if !KUNIT_ALL_TESTS
> +	depends on KUNIT && IIO
> +	default KUNIT_ALL_TESTS
> +	help
> +	  Build unit tests for __iio_chan_prefix_emit(), the helper that
> +	  builds IIO sysfs attribute name prefixes from an iio_chan_spec.
> +	  The tests are compiled into the IIO core module.

[Severity: Low]
This isn't a bug, but is this help text accurate regarding how the tests
are compiled? 

Looking at drivers/iio/test/Makefile, the test is built as a separate
object:

obj-$(CONFIG_IIO_CHANNEL_PREFIX_KUNIT_TEST) += iio-test-channel-prefix.o

rather than being compiled directly into the IIO core module itself.
Additionally, the iio-test-channel-prefix.c file explicitly imports the
EXPORTED_FOR_KUNIT_TESTING namespace, which further confirms it acts as
a standalone module testing the exported core symbols.

Could this description be updated to avoid confusion about where the test
resides?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729-ad9910-iio-driver-v10-0-aa1f6167729e@analog.com?part=7

  reply	other threads:[~2026-07-29  8:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  8:25 [PATCH v10 00/17] AD9910 Direct Digital Synthesizer Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 01/17] iio: ABI: add attributes for altcurrent channels Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 02/17] iio: ABI: raw, scale and offset for frequency/phase channels Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 03/17] iio: ABI: add parent entry for iio channels Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 04/17] iio: add IIO_FREQUENCY channel type Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 05/17] iio: core: support 64-bit register through debugfs Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 06/17] iio: core: create local __iio_chan_prefix_emit() for reuse Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 07/17] iio: test: add kunit tests for channel prefix naming generation Rodrigo Alencar via B4 Relay
2026-07-29  8:38   ` sashiko-bot [this message]
2026-07-29  8:25 ` [PATCH v10 08/17] iio: core: add hierarchical channel relationships Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 09/17] dt-bindings: iio: frequency: add ad9910 Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 10/17] iio: frequency: ad9910: initial driver implementation Rodrigo Alencar via B4 Relay
2026-07-29  8:47   ` sashiko-bot
2026-07-29  8:25 ` [PATCH v10 11/17] iio: frequency: ad9910: add basic parallel port support Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 12/17] iio: frequency: ad9910: add digital ramp generator support Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 13/17] iio: frequency: ad9910: add RAM mode support Rodrigo Alencar via B4 Relay
2026-07-29  8:45   ` sashiko-bot
2026-07-29  8:25 ` [PATCH v10 14/17] iio: frequency: ad9910: add output shift keying support Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 15/17] iio: frequency: ad9910: show channel priority in debugfs Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 16/17] iio: ABI: add docs for ad9910 sysfs and debugfs entries Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 17/17] docs: iio: add documentation for ad9910 driver Rodrigo Alencar via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729083803.C211C1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rodrigo.alencar@analog.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox