From: sashiko-bot@kernel.org
To: "Pavel Löbl" <pavel@loebl.cz>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: si544: add si549 compatible
Date: Wed, 29 Jul 2026 12:06:13 +0000 [thread overview]
Message-ID: <20260729120613.8B3A81F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260729115310.3490589-2-pavel@loebl.cz>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The updated datasheet URL for the si544 datasheet contains a capitalization typo in the path (`SkyWorks` instead of `Skyworks`), which could result in a 404 Not Found error on case-sensitive web servers.
- [Low] The binding description text was not updated to mention the new Si549 devices, leaving it inconsistent with the updated title and compatible string list.
--
--- Patch [1]: [PATCH v3 1/2] dt-bindings: clock: si544: add si549 compatible ---
commit 529dcd41cafc82a36f39e95eb442dbe9230735cf
Author: Pavel Löbl <pavel@loebl.cz>
dt-bindings: clock: si544: add si549 compatible
This commit adds the Si549 compatible strings to the si544 clock generator
binding. It also updates the datasheet links to point to Skyworks Solutions
after their acquisition of Silicon Labs.
> diff --git a/Documentation/devicetree/bindings/clock/silabs,si544.yaml b/Documentation/devicetree/bindings/clock/silabs,si544.yaml
> index f87e718671080..c58171f1bc5be 100644
> --- a/Documentation/devicetree/bindings/clock/silabs,si544.yaml
> +++ b/Documentation/devicetree/bindings/clock/silabs,si544.yaml
[ ... ]
> @@ -13,8 +13,9 @@ description: >
> Silicon Labs 514/544 programmable I2C clock generator. Details about the device
> can be found in the datasheet:
[Severity: Low]
Should the description block also be updated to mention the 549 series? The
title and compatible properties were updated to include 549, but this text
remains limited to 514/544.
> - https://www.silabs.com/Support%20Documents/TechnicalDocs/si514.pdf
> - https://www.silabs.com/documents/public/data-sheets/si544-datasheet.pdf
> + https://www.skyworksinc.com/-/media/Skyworks/SL/documents/public/data-sheets/Si514.pdf
> + https://www.skyworksinc.com/-/media/SkyWorks/SL/documents/public/data-sheets/si544-datasheet.pdf
[Severity: Low]
Is the capitalization in this URL path correct? The other updated links use
"Skyworks" in the path, but this one uses "SkyWorks". This might result in a
broken link if the web server relies on strict case-sensitivity.
> + https://www.skyworksinc.com/-/media/Skyworks/SL/documents/public/data-sheets/si549-datasheet.pdf
>
> properties:
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260729115310.3490589-1-pavel@loebl.cz?part=1
next prev parent reply other threads:[~2026-07-29 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 11:53 [PATCH v3 0/2] Add support for Si549 programmable clock Pavel Löbl
2026-07-29 11:53 ` [PATCH v3 1/2] dt-bindings: clock: si544: add si549 compatible Pavel Löbl
2026-07-29 12:06 ` sashiko-bot [this message]
2026-07-29 11:53 ` [PATCH v3 2/2] clk: si544: add support for si549 Pavel Löbl
2026-07-29 12:10 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729120613.8B3A81F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=pavel@loebl.cz \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox