Re: [PATCH v5 8/9] arm64: dts: renesas: r9a08g046: Add USB2.0 device nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree nodes are not sorted by unit address in ascending order.
--

--- Patch [8]: [PATCH v5 8/9] arm64: dts: renesas: r9a08g046: Add USB2.0 device nodes ---
commit 577e5e6e2781fd99b54a7c1f671fdf2c32513f48
Author: Biju Das <biju.das.jz@bp.renesas.com>

arm64: dts: renesas: r9a08g046: Add USB2.0 device nodes

This commit adds USB2.0 device nodes to the RZ/G3L (r9a08g046) SoC DTSI.
The additions cover the USB PHY controller, OHCI/EHCI host controllers, and
USB2 PHYs for both ports.

> diff --git a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> --- a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
[ ... ]
> +		ohci1: usb@11e90000 {
> +			compatible = "generic-ohci";
[ ... ]
> +		ehci0: usb@11e10100 {
> +			compatible = "generic-ehci";
[ ... ]
> +		usb2_phy1: usb-phy@11e90200 {
> +			compatible = "renesas,usb2-phy-r9a08g046";
[ ... ]
> +		};
> +
>  		pcie: pcie@11e40000 {
>  			reg = <0 0x11e40000 0 0x10000>;

[Severity: Low]
This isn't a bug, but are these device tree nodes ordered correctly? Standard
device tree guidelines recommend sorting child nodes by unit address in
ascending order.

In this block, ohci1 at 11e90000 is placed before ehci0 at 11e10100, and
usb2_phy1 at 11e90200 is placed before the existing pcie node at 11e40000.

Could these nodes be reordered to strictly follow the ascending unit address
sequence (11e00000, 11e10000, 11e10100, 11e10200, 11e40000, 11e90000,
11e90100, 11e90200)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729115022.222340-1-biju.das.jz@bp.renesas.com?part=8