Re: [PATCH 2/6] riscv: dts: spacemit: k1-milkv-jupiter: fix maximum CPU core voltage

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The unsafe maximum voltage limit (3.45V) for CPU core regulators `buck1` and `buck2` remains unpatched on several other SpacemiT K1 boards.
--

--- Patch [2]: [PATCH 2/6] riscv: dts: spacemit: k1-milkv-jupiter: fix maximum CPU core voltage ---
commit 2f0408a9b68518bed697666281e9fbe48abb583b
Author: Aurelien Jarno <aurelien@aurel32.net>
Subject: riscv: dts: spacemit: k1-milkv-jupiter: fix maximum CPU core voltage

This commit lowers the maximum regulator voltage for buck1 and buck2 on the
Milk-V Jupiter board from 3.45V to 1.050V. This prevents potential permanent
CPU damage from accidental overvoltage requests.

Link: https://sashiko.dev/#/message/20260728211020.1248676-2-aurelien%40aurel32.net

> diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> index b61f5995ec771..c76b91ecb914d 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> @@ -211,14 +211,14 @@ pmic@41 {
>  		regulators {
>  			buck1 {
>  				regulator-min-microvolt = <500000>;
> -				regulator-max-microvolt = <3450000>;
> +				regulator-max-microvolt = <1050000>;
>  				regulator-ramp-delay = <5000>;
>  				regulator-always-on;
>  			};
>  
>  			buck2 {
>  				regulator-min-microvolt = <500000>;
> -				regulator-max-microvolt = <3450000>;
> +				regulator-max-microvolt = <1050000>;

[Severity: High]
This is a pre-existing issue, but this commit only fixes the maximum voltage
for the Milk-V Jupiter board. Does this same CPU core overvoltage risk
exist on the other SpacemiT K1 boards?

The unsafe regulator-max-microvolt = <3450000> limit for buck1 and buck2 is
still present in several other device trees that share the same SoC and PMIC
layout:

- arch/riscv/boot/dts/spacemit/k1-bananapi-cm6.dtsi
- arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
- arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
- arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts

Should these boards also have their limits updated to 1050000 to prevent
potential CPU damage from kernel misconfigurations or a privileged userspace
writing to the regulator sysfs interface?

>  				regulator-ramp-delay = <5000>;
>  				regulator-always-on;
>  			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729150722.1598630-1-aurelien@aurel32.net?part=2