Re: [PATCH v8 1/2] dt-bindings: leds: Document LTC3208 Multidisplay LED Driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema omits `#address-cells` and `#size-cells` from the top-level `required` list, which allows structurally incomplete device tree nodes to silently pass validation.
--

--- Patch [1]: [PATCH v8 1/2] dt-bindings: leds: Document LTC3208 Multidisplay LED Driver ---
commit 40f57e6c55c9069959e21c4ed832c353a3472f0a
Author: Jan Carlo Roleda <jancarlo.roleda@analog.com>

dt-bindings: leds: Document LTC3208 Multidisplay LED Driver

This commit adds Devicetree Documentation for the LTC3208 Multidisplay LED
Driver.

> diff --git a/Documentation/devicetree/bindings/leds/adi,ltc3208.yaml b/Documentation/devicetree/bindings/leds/adi,ltc3208.yaml
> new file mode 100644
> index 0000000000000..0a01e07e0ab70
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/adi,ltc3208.yaml

[ ... ]

> +patternProperties:
> +  "^led@[0-7]$":
> +    type: object
> +    $ref: /schemas/leds/common.yaml#
> +    unevaluatedProperties: false
> +    properties:
> +      reg:
> +        description:
> +          LED Channel Number. each channel maps to a specific channel group used
> +          to configure the brightness level of the output pins corresponding to
> +          the channel.
> +        enum:
> +          - 0 # Main Channel (8-bit brightness)
> +          - 1 # Sub Channel (8-bit brightness)
> +          - 2 # AUX Channel (4-bit brightness)
> +          - 3 # Camera Channel, Low-side byte (4-bit brightness)
> +          - 4 # Camera Channel, High-side byte (4-bit brightness)
> +          - 5 # Red Channel (4-bit brightness)
> +          - 6 # Blue Channel (4-bit brightness)
> +          - 7 # Green Channel (4-bit brightness)
> +    required:
> +      - reg
> +
> +required:
> +  - compatible
> +  - reg

[Severity: Low]
Should #address-cells and #size-cells be included in this top-level required
list?

The schema defines child LED nodes in patternProperties that strictly
require a reg property. This means the parent controller node must establish
an address space for them. 

If #address-cells and #size-cells are omitted from the required list, a
device tree author could configure the node with led@X child nodes but forget
to set the addressing cells, and the structurally incomplete device tree
nodes could silently pass schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-upstream-ltc3208-v8-0-6bdcc35e65d7@analog.com?part=1