Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: pankaj.gupta@oss.nxp.com
Cc: robh@kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev,
	Frank.Li@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v32 6/7] arm64: dts: imx8ulp: add secure enclave node
Date: Thu, 30 Jul 2026 02:45:04 +0000	[thread overview]
Message-ID: <20260730024505.078AD1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260730-imx-se-if-v32-6-95f56dff4ba9@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree Schema Violation for disabled secure-enclave node
--

--- Patch [6]: [PATCH v32 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 9ea23a325f779943e0d6ff5ef6459ab8d6494416
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This patch adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. The node is kept disabled by default so it does not
impose a reserved-memory requirement on every board.

Closes: https://sashiko.dev/#/patchset/20260724-imx-se-if-v30-0-ce8ba256692c@nxp.com?part=6

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf388..38233dd74ee33 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Low]
Will this cause a devicetree schema validation warning during dtbs_check?

Because the dt-binding schema requires the 'memory-region' property for the 
"fsl,imx8ulp-se-ele-hsm" compatible string, omitting it here means any board 
that includes imx8ulp.dtsi without enabling the enclave will fail validation, 
even though the node is disabled. 

Could we avoid validation warnings by defining a dummy memory-region, or by 
restructuring how this node is included for boards that do not use the enclave?

>  	};
>  
>  	cm33: remoteproc-cm33 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-imx-se-if-v32-0-95f56dff4ba9@nxp.com?part=6

  reply	other threads:[~2026-07-30  2:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30  3:06 [PATCH v32 0/7] firmware: imx: driver for NXP secure-enclave pankaj.gupta
2026-07-30  3:06 ` [PATCH v32 1/7] Documentation/firmware: add imx/se to other_interfaces pankaj.gupta
2026-07-30  2:21   ` sashiko-bot
2026-07-30  3:06 ` [PATCH v32 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc pankaj.gupta
2026-07-30  3:06 ` [PATCH v32 3/7] firmware: imx: add driver for NXP EdgeLock Enclave pankaj.gupta
2026-07-30  2:27   ` sashiko-bot
2026-07-30  3:06 ` [PATCH v32 4/7] firmware: imx: device context dedicated to priv pankaj.gupta
2026-07-30  3:06 ` [PATCH v32 5/7] firmware: imx: adds miscdev pankaj.gupta
2026-07-30  2:31   ` sashiko-bot
2026-07-30  3:06 ` [PATCH v32 6/7] arm64: dts: imx8ulp: add secure enclave node pankaj.gupta
2026-07-30  2:45   ` sashiko-bot [this message]
2026-07-30  3:06 ` [PATCH v32 7/7] arm64: dts: imx8ulp: add reserved memory for EdgeLock Enclave pankaj.gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730024505.078AD1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=pankaj.gupta@oss.nxp.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox