Re: [PATCH v4 1/3] dt-bindings: i2c: Add Novatek NT72676 I2C controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The dt_binding_check target will fail to compile the example due to an unresolved phandle reference.
--

--- Patch [1]: [PATCH v4 1/3] dt-bindings: i2c: Add Novatek NT72676 I2C controller ---
commit 232c18d6988d7363aafdb8a90285eb1bffed9745
Author: Ben Huang <Ben_Huang@novatek.com.tw>

dt-bindings: i2c: Add Novatek NT72676 I2C controller

Add Devicetree binding documentation for Novatek NT72676 I2C
controller.

> diff --git a/Documentation/devicetree/bindings/i2c/novatek,nt72676-i2c.yaml b/Documentation/devicetree/bindings/i2c/novatek,nt72676-i2c.yaml
> new file mode 100644
> index 0000000000000..8e2595f882c44
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/novatek,nt72676-i2c.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c@fd000000 {
> +      compatible = "novatek,nt72676-i2c";
> +      reg = <0xfd000000 0x100>;
> +      interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> +      clock-frequency = <400000>;
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +    };
> +
> +    i2c@fc040a00 {
> +      compatible = "novatek,nt72676-stbc-i2c";
> +      reg = <0xfc040a00 0x40>;
> +      interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
> +      novatek,stbc-syscon = <&sysreg_system_controller>;
[Severity: Low]
Will dt_binding_check fail to compile the example here? It looks like the
label sysreg_system_controller is not defined anywhere in the example node
tree. 

Should a dummy node with the sysreg_system_controller label be added to the
example so the compiler can resolve this phandle?

> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730072529.492398-1-nina_kuo@novatek.com.tw?part=1