Re: [PATCH] dt-bindings: clock: ti: Convert APLL clock to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML conversion fails to conditionally enforce variant-specific requirements for OMAP2 vs DRA7 hardware variants.
--

--- Patch [1]: [PATCH] dt-bindings: clock: ti: Convert APLL clock to DT schema ---
commit ae216da14737ed29efd003eb0159b573f9308b0f
Author: Eduard Bostina <egbostina@gmail.com>

dt-bindings: clock: ti: Convert APLL clock to DT schema

This commit converts the Texas Instruments APLL clock bindings from a plain
text file to a DT schema.

> diff --git a/Documentation/devicetree/bindings/clock/ti/ti,apll-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,apll-clock.yaml
> new file mode 100644
> index 0000000000000..e14a76254ce77
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti/ti,apll-clock.yaml
[ ... ]
> +  clocks:
> +    minItems: 1
> +    maxItems: 2
> +    description: Link phandles of parent clocks (clk-ref and clk-bypass)
> +
> +  reg:
> +    minItems: 2
> +    maxItems: 3
[ ... ]
> +  ti,clock-frequency:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: static clock frequency for the clock (OMAP2 only)
> +
> +  ti,idlest-shift:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: bit-shift for the idlest field (OMAP2 only)
> +
> +  ti,bit-shift:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: bit-shift for enable and autoidle fields (OMAP2 only)
> +
> +required:
> +  - compatible
> +  - "#clock-cells"
> +  - clocks
> +  - reg
> +
> +unevaluatedProperties: false

[Severity: Medium]
Does this YAML conversion fail to enforce the OMAP2-specific required
properties that were described in the original text binding?

The original text binding indicated that ti,clock-frequency, ti,idlest-shift,
and ti,bit-shift were required for the OMAP2 hardware variant. By dropping
these properties from the required list entirely and leaving clocks and reg
with loose bounds, device trees with incomplete OMAP2 configurations will
now silently pass schema validation.

Should this schema include an allOf conditional block matching the
ti,omap2-apll-clock compatible string to properly enforce these properties
and the specific minItems/maxItems constraints for each generation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730083019.29998-1-egbostina@gmail.com?part=1