From: sashiko-bot@kernel.org
To: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>
Cc: robh@kernel.org, linux-pci@vger.kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector
Date: Thu, 30 Jul 2026 12:10:49 +0000 [thread overview]
Message-ID: <20260730121050.173F91F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260730-eliza_evk-v7-2-7ac7b66a3e6d@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect GPIO polarity for w-disable2-gpios inverts M.2 Bluetooth radio disable logic.
--
--- Patch [2]: [PATCH v7 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector ---
commit 1b7021041bf505a0f78e56766606ecebc1d465b4
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector
This commit enables the PCIe0 root port and its QMP PHY for the Eliza EVK
board's M.2 E key connector. It provisions a 3.3V regulator supply via an
I2C GPIO expander and defines the connector to host a WLAN card over PCIe
and a Bluetooth device over UART.
> diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> index e47b24f8b8277..b35fffb509765 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
[ ... ]
> + connector-0 {
> + compatible = "pcie-m2-e-connector";
> + vpcie3v3-supply = <&vreg_pcie_m_3p3>;
> + w-disable1-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
> + w-disable2-gpios = <&pm8550vs_g_gpios 4 GPIO_ACTIVE_HIGH>;
[Severity: Medium]
Does this GPIO polarity correctly model the M.2 specification? The M.2 standard
defines W_DISABLE2# as an active-low signal, meaning a physical LOW disables
the radio.
If the pwrseq-pcie-m2 driver expects an active-low signal and de-asserts
the GPIO to enable the radio, specifying GPIO_ACTIVE_HIGH here will cause
the physical pin to be driven LOW instead, inadvertently holding the
Bluetooth radio in a disabled state.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-eliza_evk-v7-0-7ac7b66a3e6d@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-07-30 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 12:00 [PATCH v7 0/3] arm64: dts: qcom: eliza-evk: Enable PCIe0 and PCIe1 with M.2 and TC9563 switch Krishna Chaitanya Chundru
2026-07-30 12:00 ` [PATCH v7 1/3] arm64: dts: qcom: eliza: Add PCIe PHY and controller nodes Krishna Chaitanya Chundru
2026-07-30 12:22 ` sashiko-bot
2026-07-30 12:00 ` [PATCH v7 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector Krishna Chaitanya Chundru
2026-07-30 12:10 ` sashiko-bot [this message]
2026-07-30 12:00 ` [PATCH v7 3/3] arm64: dts: qcom: eliza-evk: Add PCIe1 with TC9563 PCIe switch Krishna Chaitanya Chundru
2026-07-30 12:24 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730121050.173F91F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox