From: sashiko-bot@kernel.org
To: "Stefan Popa" <stefan.popa@analog.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org,
linux-hwmon@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: adc: add adi,max40080
Date: Thu, 30 Jul 2026 13:25:23 +0000 [thread overview]
Message-ID: <20260730132524.0F4DD1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260730131738.822405-2-stefan.popa@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The MAINTAINERS entry for 'MAXIM MAX40080 CURRENT SENSE AMPLIFIER DRIVER' is incorrectly appended to the very end of the file, placing it after the catch-all 'THE REST' section.
--
--- Patch [1]: [PATCH v6 1/2] dt-bindings: iio: adc: add adi,max40080 ---
commit 4f01f75006cab658c6276517a4096c41a91e9b17
Author: Stefan Popa <stefan.popa@analog.com>
dt-bindings: iio: adc: add adi,max40080
This commit adds device tree bindings for the Analog Devices MAX40080
bidirectional current-sense amplifier. It outlines the required properties
and creates a new maintainer entry for the driver.
> diff --git a/MAINTAINERS b/MAINTAINERS
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
[ ... ]
> @@ -27447,3 +27447,11 @@ S: Buried alive in reporters
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> F: *
> F: */
> +
> +MAXIM MAX40080 CURRENT SENSE AMPLIFIER DRIVER
[Severity: Low]
This isn't a bug, but should this new entry be sorted alphabetically within
the file? Appending it at the very bottom places it after the catch-all
fallback section, which violates the standard sorting convention.
> +M: Ciprian Hegbeli <ciprian.hegbeli@analog.com>
> +M: Stefan Popa <stefan.popa@analog.com>
> +L: linux-iio@vger.kernel.org
> +S: Supported
> +W: https://ez.analog.com/linux-software-drivers
> +F: Documentation/devicetree/bindings/iio/adc/adi,max40080.yaml
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260730131738.822405-1-stefan.popa@analog.com?part=1
next prev parent reply other threads:[~2026-07-30 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 13:17 [PATCH v6 0/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-07-30 13:17 ` [PATCH v6 1/2] dt-bindings: iio: adc: add adi,max40080 Stefan Popa
2026-07-30 13:25 ` sashiko-bot [this message]
2026-07-30 13:17 ` [PATCH v6 2/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-07-30 13:29 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730132524.0F4DD1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox