From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, Bruno Thomsen <bruno.thomsen@gmail.com>
Subject: [PATCH 2/2] hwmon: (tmp401) add channel label support
Date: Thu, 30 Jul 2026 15:30:58 +0200 [thread overview]
Message-ID: <20260730133058.14731-2-bruno.thomsen@gmail.com> (raw)
In-Reply-To: <20260730133058.14731-1-bruno.thomsen@gmail.com>
Allow userspace application to select temperature sensor based on
channel label in device tree, just like it's possible in lm90.
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
drivers/hwmon/tmp401.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
index ca0ff525ea29..13c5da4df447 100644
--- a/drivers/hwmon/tmp401.c
+++ b/drivers/hwmon/tmp401.c
@@ -117,6 +117,7 @@ struct tmp401_data {
struct hwmon_channel_info temp_info;
const struct hwmon_channel_info *info[3];
struct hwmon_chip_info chip;
+ const char *channel_label[4];
};
/* regmap */
@@ -467,6 +468,16 @@ static int tmp401_read(struct device *dev, enum hwmon_sensor_types type,
}
}
+static int tmp401_read_string(struct device *dev, enum hwmon_sensor_types type,
+ u32 attr, int channel, const char **str)
+{
+ struct tmp401_data *data = dev_get_drvdata(dev);
+
+ *str = data->channel_label[channel];
+
+ return 0;
+}
+
static int tmp401_write(struct device *dev, enum hwmon_sensor_types type,
u32 attr, int channel, long val)
{
@@ -502,6 +513,7 @@ static umode_t tmp401_is_visible(const void *data, enum hwmon_sensor_types type,
case hwmon_temp_fault:
case hwmon_temp_lowest:
case hwmon_temp_highest:
+ case hwmon_temp_label:
return 0444;
case hwmon_temp_min:
case hwmon_temp_max:
@@ -521,6 +533,7 @@ static umode_t tmp401_is_visible(const void *data, enum hwmon_sensor_types type,
static const struct hwmon_ops tmp401_ops = {
.is_visible = tmp401_is_visible,
.read = tmp401_read,
+ .read_string = tmp401_read_string,
.write = tmp401_write,
};
@@ -531,6 +544,7 @@ static int tmp401_init_client(struct tmp401_data *data)
struct regmap *regmap = data->regmap;
u32 config, config_orig;
int ret;
+ u32 ch;
u32 val = 0;
s32 nfactor = 0;
@@ -590,6 +604,26 @@ static int tmp401_init_client(struct tmp401_data *data)
return ret;
}
+ for_each_child_of_node_scoped(data->client->dev.of_node, child) {
+ ret = of_property_read_u32(child, "reg", &ch);
+ if (ret) {
+ dev_err(&data->client->dev, "missing reg property of %pOFn\n", child);
+ return ret;
+ }
+ if (ch >= ARRAY_SIZE(data->temp_channel_config) ||
+ !data->temp_channel_config[ch]) {
+ dev_err(&data->client->dev, "invalid reg %u of %pOFn\n", ch, child);
+ return -EINVAL;
+ }
+ ret = of_property_read_string(child, "label", &data->channel_label[ch]);
+ if (ret == -ENODATA || ret == -EILSEQ) {
+ dev_err(&data->client->dev, "invalid label property in %pOFn\n", child);
+ return ret;
+ }
+ if (data->channel_label[ch])
+ data->temp_channel_config[ch] |= HWMON_T_LABEL;
+ }
+
return 0;
}
--
2.55.0
next prev parent reply other threads:[~2026-07-30 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 13:30 [PATCH 1/2] dt-bindings: hwmon: ti,tmp401: Add label property Bruno Thomsen
2026-07-30 13:30 ` Bruno Thomsen [this message]
2026-07-30 13:46 ` [PATCH 2/2] hwmon: (tmp401) add channel label support sashiko-bot
2026-07-30 13:42 ` [PATCH 1/2] dt-bindings: hwmon: ti,tmp401: Add label property sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730133058.14731-2-bruno.thomsen@gmail.com \
--to=bruno.thomsen@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox