Re: [PATCH v8 08/18] media: iris: Add platform data field for watchdog interrupt mask

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete refactoring of watchdog interrupt bitmask. The new `wd_intr_mask` field is used for clearing and handling interrupts, but the hardware unmasking in `iris_vpu_interrupt_init()` still uses the hardcoded `WRAPPER_INTR_MASK_A2HWD_BMSK` (`BIT(3)`).
--

--- Patch [8]: [PATCH v8 08/18] media: iris: Add platform data field for watchdog interrupt mask ---
commit 7b1829b3b98fff57fbf33321045b38db86f344d4
Author: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>

media: iris: Add platform data field for watchdog interrupt mask

This commit introduces a new platform data field, wd_intr_mask, to support
different watchdog interrupt bitmasks per platform. It updates the interrupt
clearing and watchdog handling routines to use this field instead of the
hardcoded WRAPPER_INTR_STATUS_A2HWD_BMSK macro.

> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_register_defines.h b/drivers/media/platform/qcom/iris/iris_vpu_register_defines.h
> index 72168b9ffa738..4fffa094c52fe 100644
> --- a/drivers/media/platform/qcom/iris/iris_vpu_register_defines.h
> +++ b/drivers/media/platform/qcom/iris/iris_vpu_register_defines.h
> @@ -41,7 +41,6 @@
>  #define MSK_CORE_POWER_ON			BIT(1)
>  
>  #define WRAPPER_INTR_STATUS			(WRAPPER_BASE_OFFS + 0x0C)
> -#define WRAPPER_INTR_STATUS_A2HWD_BMSK		BIT(3)
>  #define WRAPPER_INTR_STATUS_A2H_BMSK		BIT(2)
>  
>  #define WRAPPER_INTR_MASK			(WRAPPER_BASE_OFFS + 0x10)

[Severity: Medium]
While WRAPPER_INTR_STATUS_A2HWD_BMSK was removed and replaced with the
platform-specific wd_intr_mask, does iris_vpu_interrupt_init() still
hardcode the mask?

drivers/media/platform/qcom/iris/iris_vpu_common.c:iris_vpu_interrupt_init() {
    ...
	mask_val &= ~(WRAPPER_INTR_MASK_A2HWD_BMSK |
		      WRAPPER_INTR_MASK_A2HCPU_BMSK);
    ...
}

If AR50LT has a different bit for the watchdog interrupt, will it
remain masked in the hardware because WRAPPER_INTR_MASK_A2HWD_BMSK is
still defined as BIT(3)?

Should the WRAPPER_INTR_MASK_A2HWD_BMSK macro also be removed and replaced
with wd_intr_mask during initialization?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-iris-ar50lt-v8-0-6597c08cea6f@oss.qualcomm.com?part=8