Re: [PATCH v3 1/3] dt-bindings: iio: proximity: add Sharp GP2AP070S proximity sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `vled-supply` property is missing from the `required` list, despite the hardware requiring it for core functionality.
--

--- Patch [1]: [PATCH v3 1/3] dt-bindings: iio: proximity: add Sharp GP2AP070S proximity sensor ---
commit a5f76b868834c635a43cd3859fdfeb8667e96336
Author: Kaustabh Chakraborty <kauschluss@disroot.org>

dt-bindings: iio: proximity: add Sharp GP2AP070S proximity sensor

This commit introduces the device tree binding for the Sharp GP2AP070S
proximity sensor. The sensor expects two voltage supplies, one for the
core and one for the infrared LED.

> diff --git a/Documentation/devicetree/bindings/iio/proximity/sharp,gp2ap070s.yaml b/Documentation/devicetree/bindings/iio/proximity/sharp,gp2ap070s.yaml
> new file mode 100644
> index 0000000000000..73f0abc1f09cb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/sharp,gp2ap070s.yaml

[ ... ]

> +  vdd-supply:
> +    description: Voltage supply for the internal circuitry
> +
> +  vled-supply:
> +    description: Voltage supply for the IR LED
> +
> +  proximity-near-level: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vdd-supply

[Severity: Medium]
Since the commit message indicates the hardware expects two voltage supplies,
should vled-supply also be included in this required list?

Without it, device trees missing the vled-supply property will silently pass
schema validation, which could lead to incomplete configurations.

> +
> +additionalProperties: false

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-gp2ap070s-v3-0-d1f5cecf9fe7@disroot.org?part=1