From: sashiko-bot@kernel.org
To: "Esteban Urrutia" <esteuwu@proton.me>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475
Date: Fri, 31 Jul 2026 05:10:48 +0000 [thread overview]
Message-ID: <20260731051049.445451F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260731-sm8475-pmic-glink-v2-1-28c04928ef22@proton.me>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The new compatible string `qcom,sm8475-pmic-glink` is missing from driver match tables, which will cause functional failures for UCSI (Type-C PD) and potentially the Battery Manager.
--
--- Patch [1]: [PATCH v2 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475 ---
commit 6029f64195b0d5f78f56d1dc22f18faabeb47c53
Author: Esteban Urrutia <esteuwu@proton.me>
dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475
This commit adds a new compatible string for the SM8475 SoC to the pmic-glink
binding. It separates the SM8475 from SM8450 and SM8550 due to process design
differences.
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 16ad4f5698fc3..c80c724113816 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -30,6 +30,7 @@ properties:
> - qcom,sc8280xp-pmic-glink
> - qcom,sm8350-pmic-glink
> - qcom,sm8450-pmic-glink
> + - qcom,sm8475-pmic-glink
[Severity: High]
Should this compatible string also be added to the driver match tables in
drivers/usb/typec/ucsi/ucsi_glink.c and drivers/power/supply/qcom_battmgr.c?
Looking at pmic_glink_ucsi_of_quirks in drivers/usb/typec/ucsi/ucsi_glink.c,
missing this compatible string causes of_match_device to return NULL. Since
both SM8450 and SM8550 require quirk_sm8450 to enable UCSI_DELAY_DEVICE_PDOS,
missing this quirk on SM8475 might lead to USB Type-C Power Delivery
negotiation failures.
Additionally, in qcom_battmgr_of_variants in qcom_battmgr.c, an unlisted
compatible string implicitly falls back to QCOM_BATTMGR_SM8350. Does SM8475
require the QCOM_BATTMGR_SM8550 variant instead, and could this cause battery
manager regressions?
> - qcom,sm8550-pmic-glink
> - const: qcom,pmic-glink
> - items:
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-sm8475-pmic-glink-v2-0-28c04928ef22@proton.me?part=1
next prev parent reply other threads:[~2026-07-31 5:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 5:00 [PATCH v2 0/2] Support for pmic-glink in SM8475 Esteban Urrutia via B4 Relay
2026-07-31 5:00 ` [PATCH v2 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475 Esteban Urrutia via B4 Relay
2026-07-31 5:10 ` sashiko-bot [this message]
2026-07-31 9:58 ` Krzysztof Kozlowski
2026-07-31 5:00 ` [PATCH v2 2/2] usb: typec: ucsi: ucsi_glink: " Esteban Urrutia via B4 Relay
2026-07-31 5:17 ` sashiko-bot
2026-07-31 5:40 ` Esteban Urrutia
2026-07-31 9:59 ` Krzysztof Kozlowski
2026-07-31 10:00 ` [PATCH v2 0/2] Support for pmic-glink in SM8475 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731051049.445451F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=esteuwu@proton.me \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox