Re: [PATCH v6 1/2] dt-bindings: usb: Add ITE IT8851/IT8853 Type-C PD controllers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `#address-cells` and `#size-cells` properties are omitted from the `required` list, which allows structurally invalid device tree nodes with unit-addressed children to pass schema validation.
--

--- Patch [1]: [PATCH v6 1/2] dt-bindings: usb: Add ITE IT8851/IT8853 Type-C PD controllers ---
commit 71cd2c5efffec87b0126175a226c30906e7e82a5
Author: Amber Kao <amber.kao@ite.com.tw>

dt-bindings: usb: Add ITE IT8851/IT8853 Type-C PD controllers

This commit adds device tree bindings for the ITE IT8851 and IT8853 I2C-based
USB Type-C Power Delivery controllers. It defines the required properties
and child nodes for handling one or two Type-C ports depending on the
hardware variant.

> diff --git a/Documentation/devicetree/bindings/usb/ite,it8851.yaml b/Documentation/devicetree/bindings/usb/ite,it8851.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ite,it8851.yaml
[ ... ]
> +patternProperties:
> +  '^connector@[01]$':
> +    $ref: /schemas/connector/usb-connector.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

[Severity: Low]
Should #address-cells and #size-cells be included in this required block?

Since this binding has unit-addressed child nodes (connector@0 and
connector@1), omitting these properties from the required list allows
structurally invalid device tree nodes to pass YAML schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-ucsi-itepd-v6-0-d25ae12b181f@ite.com.tw?part=1