Re: [PATCH v7 5/9] arm64: dts: qcom: kodiak: Enable CDSP & Modem cooling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Meaningful code and commit message mismatch regarding cooling map removals on modem boards.
--

--- Patch [5]: [PATCH v7 5/9] arm64: dts: qcom: kodiak: Enable CDSP & Modem cooling ---
commit 8e78187a5b8612e6bf1ed1720f537ae83abca9c8
Author: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>

arm64: dts: qcom: kodiak: Enable CDSP & Modem cooling

This commit sets up cooling maps for the CDSP and Modem on kodiak, throttling
them at 100 degrees C and 95 degrees C respectively. It also deletes the
inherited cooling maps on non-modem boards to prevent compilation errors
since they lack the remoteproc_mpss node.

> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi
> index ac89724ee0993..891941906a467 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi

[ ... ]

> @@ -28,8 +28,18 @@ &ipa {
>  	status = "okay";
>  };
>  
> +/delete-node/ &mdmss0_pa_cooling_map;
> +/delete-node/ &mdmss0_modem_cooling_map;
> +/delete-node/ &mdmss1_pa_cooling_map;
> +/delete-node/ &mdmss1_modem_cooling_map;
> +/delete-node/ &mdmss2_pa_cooling_map;
> +/delete-node/ &mdmss2_modem_cooling_map;
> +/delete-node/ &mdmss3_pa_cooling_map;
> +/delete-node/ &mdmss3_modem_cooling_map;
> +
>  &remoteproc_mpss {
>  	compatible = "qcom,sc7280-mss-pil";
> +	/delete-property/ #cooling-cells;

[Severity: Medium]
The commit message states that inherited mdmss cooling-map nodes are removed
because the remoteproc_mpss node doesn't exist on non-modem boards. However,
this code deletes the cooling maps and the #cooling-cells property from
sc7280-herobrine-lte-sku.dtsi, which is an LTE board with a modem.

Is the description in the commit message accurate?

It appears the actual reason for the deletion in the LTE SKU is that it
overrides the compatible string to qcom,sc7280-mss-pil, which does not support
the #cooling-cells property. 

Could the commit message be updated to be more precise about why the nodes
are removed from this specific modem-enabled board?

>  	reg = <0 0x04080000 0 0x10000>, <0 0x04180000 0 0x48>;
>  	reg-names = "qdsp6", "rmb";
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-b4-qmi-tmd-v7-0-3befd44403d5@oss.qualcomm.com?part=5