From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 696DF3D6682 for ; Fri, 31 Jul 2026 11:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785497809; cv=none; b=iwcZC+A9s2h1fyob9iO0WjjbrBUxn9HH45+hAmRwCvavM2HvIov13OVJZTnQcjYYoHRBQCqGNUPZ9wKvpXCfewWsP/fxgBLXNlGnotKd57A5NIU+mQNFc4e1cK6LmBkRbyaSBZQPl+tFo6fwITgt06YrZ351jzh0WmrvuF3KVDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785497809; c=relaxed/simple; bh=AUKrB+1UwvRA+EobKyrqOVgmoMGLyj3fg3zoQatKMk0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GRBavwzIUD8wKxy0XdMeftwY9k3OcqsR5oDiPSxE7UEGrHOxZUtZNiULjoZ4CkC/DbhIqgHkVoStUruA/sQHCu5HP+dD93KkF32zQOY25zV7tfq9vzOYzHoszM2HoR/9SHYjWVqNF8DUbrn3Veb2ZPWjLHPViA4bkRiCISzHsHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bp11gIzP; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bp11gIzP" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47ddf7b09aaso897656f8f.3 for ; Fri, 31 Jul 2026 04:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785497806; x=1786102606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0oYKY0Gc5U72MShEoavxG+AazK3v/FMxLUqW5uFuuYY=; b=Bp11gIzPk6NYgpg1sKmqDzQj0k+pJwwA7Tgr93OPALc8zQZOc/iNVXpdyyk/n4mfrL wy16LTzLImgsBmwwPFkgIrAqFCZOdg3LEzZK3XaF8HFwhndS6okO6DuyZfgwkVHnk1k/ ObLtsFusHDLCy5SW1CZjelqFAtFWCmrNXK3zLLWXPnXRoDtEnOCua2sueJrwvauZfPec q1BmTleFvzO4cbAgh/xZPuEFP6DDwiqA3eFcg5WyiG3zUx3K3K/Q92QxHwK8yHqDCqo9 S+NqHR8TpKLwscFv/GU5LMgWHaOWe7GyojfjRjxlcdDsj5eH+KKNVvGJ43xnMJL8hYj7 7uzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785497806; x=1786102606; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0oYKY0Gc5U72MShEoavxG+AazK3v/FMxLUqW5uFuuYY=; b=bfIrfGqy+3Dr9anaPNI+k7833bgcRrg5OsZ0FBr8s58kAE0UoUkKkpQZ5qsuftqaHp 8qRUsLX+RTxl97zl194LdcQsraJU9IQoGktVUxK/M90F4SZiLktChWrZn04OZXabW0Ws hyaOsE2ihhC8t+9E6j+QPpIuiIZhke8DKileixO+i9R4DmyLEAva7gfq7quLKFYmLCJ7 SP5Tl/1qEe8/hI8NIbETjLBUMGJXVLxM09iqkE/+jfNVFgfPWBOCbAqsnD7Msoc7MaOw NvTKtF17/8ojry+pA5/ufTrQkiMFafqnR7BnCwmdnfA0KQ6fXw1NJ+nt5sMQsHCQye6W Jc3g== X-Forwarded-Encrypted: i=1; AHgh+RrGEpsx5pC9Xulh3sGYeSmFPhW7gJMKsoakVptqxrDV2jtYImhYxFMIa3+oXoMSNPSNL+eiPBavt77y@vger.kernel.org X-Gm-Message-State: AOJu0YwXf8gpy/CYDCcuCsyL6aZQQ4ILvSOpb4+064C/6kiRNX9tMxVE 3n9jmf5P9Ep/9g+k6xAUYXrCYSWuZZUpEDUTF3rw4cE5P6o04NwlIex0 X-Gm-Gg: AR+sD107x4L/kMp2mzZFwBZMU44UJBsR+lAqJb80o6avscWp18H3Ca30iN7S7LrBTB9 0vTN3faozH6iK6oif73QhRxxqoRH/pBFhMG1toba77sLpYoekeQmg+Caa0aI7rbcMQiGHeCzrRu nmSobj3Kk4KZJ6rouP3T0MyyEm+PprwpmQQkhvtiqoboI8u1x5OrAfouBKPipaJASeCbvV6fRo8 ZVimXCEMolH0pmlSCCRdpXQGXmmYFgvBP7PU35Fasgm1AfoB9AE3l6IV2Rw9j7OXWoSODtnE/X6 ASAIy8dSAmbOvYUku1tfHZVxyfSyYDwh08zKHYg240VCHayeono9sVbzhBcRa8sRVPB1uq1Addk lmynt7myyh0C3CIMWLxuG/BpCw8hj8eIjAaoEmZQlXl0WJjsWRXSrnjkVFaB6Ph+CwHKGySq8rb b/NHZaGMawTcXy3AlSPu5HVTitxN6kbmQD6vFEW83v/GrPVDYLUMlN9veYEuQXUDq9qjoLfOOou zFjp/vH+A== X-Received: by 2002:a05:6000:2904:b0:47f:2de3:b351 with SMTP id ffacd0b85a97d-47fd2adcad1mr4260062f8f.26.1785497805482; Fri, 31 Jul 2026 04:36:45 -0700 (PDT) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a0c8bsm3670646f8f.34.2026.07.31.04.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 04:36:44 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Helge Deller , Svyatoslav Ryhel Cc: Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, mfd@lists.linux.dev, linux-fbdev@vger.kernel.org Subject: [PATCH v6 00/14] mfd: lm3533: convert to OF bindings, improve support Date: Fri, 31 Jul 2026 14:36:18 +0300 Message-ID: <20260731113632.158440-1-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert LM3533 to OF bindings, add missing VIN supply, add support for setting mapping mode and LED sources based on device tree. --- Changes in v2: schema - maximum led sources for leds set to 4 - anyOf > oneOf in ALS - improved ALS descriptions - adjusted example drivers - dropped devm convertion of irq and mfd helpers - all als configuration moved into lm3533_als_setup - added regulator/consumer.h - lm3533_bl_setup set before sysfs_create_group in backlight - added check if LVLED is valid - LM3533_REG_OUTPUT_CONF1 > LM3533_REG_OUTPUT_CONF2 for LVLED4 and LVLED5 Changes in v3: - ohm -> ohms - added default PWM mask to schema - added commit removing driver regmap wrappers - added commits which flatten pdata helpers - adjusted check if als->irq > 0 since als->irq can be negative if error/missing - added count for children defined in device tree and mfd_cell is allocated via devm_kcalloc to be able to contain all of them - fixed backlight boundary check - fixed count increased unconditionally - dev_err returns node name instead of reg value - LM3533_MAX_CURRENT_* defines moved to common header since they are used to clamp current values read from the tree - mapping mode commit splitted into 2 (sysfs logic improvement > mode from DT) - backlight mode configuration set before sysfs group is created - fixed LVLED check on LEDs setup - added check if HVLED is valid - fixed wrong err_sysfs_remove goto in lm3533_bl - added commit implementing backlight_scale property Changes in v4: - fixed regmap_update_bits val and mask swap in lm3533_als_set_int_mode - fixed als->irq check in store_thresh_either_en - removed clamping of r_select in als driver - added use_of_reg and of_reg for backlight and leds registration - added intermediate step in asigning props.brightness - fixed HVLED/LVLED configuration overwriting - added bounds check for num_leds in leds and backlight driver - switched to regmap_clean/set/assign/test_bits helpers where appropriate - dropped extern from header function declartions - switched lm3533 pointer in cell structures to regmap - sysfs_create_group > device_add_group - changes in backlight sysfs were expanded to all properties Changes in v5: - aligned driver helpers to use u32 - child nodes parsing linked with 'else if' to ensure there is one call per node - removed redundant pwm var init for leds - fixed regmap_test_bits return check - fixed leds and backlight counting handling - iterator variables made scoped - lm3533_als_setup() set to exit after mode set if m0de is pwm Changes in v6: - expanded commit message in OF conversion commit - restored original comment regarding PWM mode of ALS - switched to FIELD_PREP macro in core for helper flattening --- Svyatoslav Ryhel (14): dt-bindings: leds: Document TI LM3533 LED controller mfd: lm3533: Remove driver specific regmap wrappers mfd: lm3533: Remove extern from shared functions in the header mfd: lm3533: Pass only regmap and light sensor presence to child devices iio: light: lm3533-als: Remove redundant pdata helpers mfd: lm3533-core: Remove redundant pdata helpers mfd: lm3533: Use dev_groups in struct device_driver mfd: lm3533: Convert to use OF bindings mfd: lm3533: Add support for VIN power supply mfd: lm3533: Set DMA mask video: backlight: lm3533_bl: Improve logic of sysfs functions video: backlight: lm3533_bl: Set initial mapping mode from DT video: backlight: lm3533_bl: Implement backlight_scale property video: leds: backlight: lm3533: Support getting LED sources from DT .../leds/backlight/ti,lm3533-backlight.yaml | 69 ++++ .../bindings/leds/ti,lm3533-leds.yaml | 67 ++++ .../devicetree/bindings/leds/ti,lm3533.yaml | 169 ++++++++ drivers/iio/light/lm3533-als.c | 179 ++++----- drivers/leds/leds-lm3533.c | 181 ++++++--- drivers/mfd/lm3533-core.c | 378 +++++++----------- drivers/mfd/lm3533-ctrlbank.c | 33 +- drivers/video/backlight/lm3533_bl.c | 231 ++++++----- include/linux/mfd/lm3533.h | 75 +--- 9 files changed, 818 insertions(+), 564 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/backlight/ti,lm3533-backlight.yaml create mode 100644 Documentation/devicetree/bindings/leds/ti,lm3533-leds.yaml create mode 100644 Documentation/devicetree/bindings/leds/ti,lm3533.yaml -- 2.53.0