Re: [PATCH v11 1/2] dt-bindings: media: i2c: Add mira220 image sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing `anyOf` from `data-lanes` without explicitly adding `minItems: 1` implicitly restricts `data-lanes` to strictly 2 lanes, rejecting valid 1-lane configurations.
--

--- Patch [1]: [PATCH v11 1/2] dt-bindings: media: i2c: Add mira220 image sensor ---
commit d966c6286995396b61812a3a1c5b7c1683f0cbf3
Author: Philippe Baetens <philippebaetens@gmail.com>
Subject: dt-bindings: media: i2c: Add mira220 image sensor

Adds device tree bindings for the AMSOSRAM Mira220 image sensor.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml

[ ... ]

> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            items:
> +              - const: 1
> +              - const: 2

[Severity: Low]
Does this configuration implicitly restrict data-lanes to strictly 2 lanes?

By defining items as a two-element array without overriding minItems, dtschema
automatically infers minItems: 2. This overrides the minItems: 1 inherited
from video-interfaces.yaml, which causes valid 1-lane device tree
configurations like data-lanes = <1>; to fail schema validation.

Could an explicit minItems: 1 be added to allow 1-lane configurations?

> +
> +        required:
> +          - data-lanes
> +          - link-frequencies

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-mira220-v11-0-1295fe17021d@ideasonboard.com?part=1