Re: [PATCH v2 2/3] arm64: dts: qcom: Add Glymur-based Lenovo Yoga Slim 7x Gen11

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] The `lpass_vamacro` sound node is missing the `vdd-micb-supply` property, which is required to bias the digital microphones.
- [High] The WCN7850 PMU is incorrectly configured with a 1.8V regulator for its 0.95V and 1.2V rails.
- [Low] Unused pinctrl state `nvme_sec_reg_en` defined in PMIC GPIOs.
--

--- Patch [2]: [PATCH v2 2/3] arm64: dts: qcom: Add Glymur-based Lenovo Yoga Slim 7x Gen11 ---
commit dd05ca8f0ca39458a10b38cd0e585f0cd4a934d3
Author: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

arm64: dts: qcom: Add Glymur-based Lenovo Yoga Slim 7x Gen11

This commit introduces a new device tree for the Glymur-based Lenovo Yoga 
Slim 7x Gen11. It mentions several working features, including audio playback
and capture, display, keyboard, touchpad, Wi-Fi, and Bluetooth.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts
> new file mode 100644
> index 0000000000000..ecc8c34fb983b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts

[ ... ]

> +	wcn7850-pmu {
> +		compatible = "qcom,wcn7850-pmu";
> +
> +		vdd-supply = <&vreg_wcn_0p95>;
> +		vddio-supply = <&vreg_l15b_e0>;
> +		vddaon-supply = <&vreg_l15b_e0>;
> +		vdddig-supply = <&vreg_l15b_e0>;
> +		vddrfa1p2-supply = <&vreg_l15b_e0>;
> +		vddrfa1p8-supply = <&vreg_l15b_e0>;

[Severity: High]
Is the 1.8V regulator (vreg_l15b_e0) correctly assigned here?

The PMU's Always-On (vddaon) and Digital (vdddig) rails require ~0.95V,
and vddrfa1p2 requires 1.2V.

Connecting them to a 1.8V LDO could break power management or lead to
undefined behavior during WCN power sequencing.

[ ... ]

> +&lpass_vamacro {
> +	pinctrl-0 = <&dmic01_default>, <&dmic23_default>;
> +	pinctrl-names = "default";
> +	qcom,dmic-sample-rate = <4800000>;
> +};

[Severity: High]
Is the vdd-micb-supply property missing from the lpass_vamacro node?

Without the microphone bias supply configured, the VA macro driver cannot
enable the required regulator to power the digital microphones, which causes
audio capture to fail.

The commit message states "Audio playback and capture" is working, but it
seems this configuration is incomplete. The 1.8V regulator vreg_l1b_e0 is
defined in the device tree but unreferenced; was it intended for this?

[ ... ]

> +&pmh0110_f_e1_gpios {
> +	nvme_sec_reg_en: nvme-reg-en-state {
> +		pins = "gpio14";
> +		function = "normal";
> +		bias-disable;
> +	};
> +};

[Severity: Low]
Is this pinctrl state nvme_sec_reg_en used anywhere?

It appears to be completely unreferenced by any regulator or device.
The vreg_nvme regulator correctly references nvme_reg_en from
pmh0101_gpios instead.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-topic-yoga_submission-v2-0-f1887031da4f@oss.qualcomm.com?part=2