Re: [PATCH 3/3] pinctrl: qcom: Add SM8475 pinctrl driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Duplicate element 'gpio81' in `prng_rosc_groups` array.
--

--- Patch [3]: [PATCH 3/3] pinctrl: qcom: Add SM8475 pinctrl driver ---
commit 69bbbdbf43f15e9fcc85a840c3553ca43e151ad0
Author: Esteban Urrutia <esteuwu@proton.me>

pinctrl: qcom: Add SM8475 pinctrl driver

This commit introduces a new pin controller driver for the Qualcomm SM8475
platform. It separates the SM8475 configurations from the SM8450 driver due
to differences in PLL clock groups.

> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8475.c b/drivers/pinctrl/qcom/pinctrl-sm8475.c
> new file mode 100644
> index 0000000000000..79e2fce11d36d
> --- /dev/null
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8475.c

[ ... ]

> +static const char * const pri_mi2s_groups[] = {
> +	"gpio125",
> +};
> +
> +static const char * const prng_rosc_groups[] = {
> +	"gpio73", "gpio75", "gpio81", "gpio83",  "gpio81",
> +};

[Severity: Low]
This isn't a bug, but it looks like "gpio81" is listed twice in the
prng_rosc_groups array. Was this intentional, or a copy-paste error?

> +
> +static const char * const qdss_cti_groups[] = {
> +	"gpio2", "gpio80", "gpio81", "gpio82", "gpio83", "gpio84", "gpio85", "gpio93",
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-sm8475-tlmm-v1-0-3007a8e4aa62@proton.me?part=3