Re: [PATCH v8 20/21] dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Changing `#sound-dai-cells` to `const: 1` without updating in-tree DTS files in the same series breaks `dtbs_check` bisectability.
--

--- Patch [20]: [PATCH v8 20/21] dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells ---
commit afb955faffe4407ec88a5c35c168c8dd82310361
Author: Sebastian Reichel <sebastian.reichel@collabora.com>

dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells

This commit updates the #sound-dai-cells property for the Rockchip dw-dp
controllers from 0 to 1 to allow selecting between I2S and S/PDIF interfaces.
It anticipates future Multi Stream Transport (MST) support where additional
numbers will identify both the interface and the stream.

> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> index 2b0d9e23e9432..c4f8959dd65da 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml

[ ... ]

> @@ -83,7 +83,8 @@ properties:
>      maxItems: 1
>  
>    "#sound-dai-cells":
> -    const: 0
> +    const: 1

[Severity: Low]
Does this change break dtbs_check bisectability for RK3588 boards?

The commit message mentions that the mainline rk3588 DTS include sets this
to 0 and will be fixed up separately. If the in-tree DTS files (such as
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi) are not updated in the same
patch series, make dtbs_check will fail on those boards during a bisect
until the separate fix is applied.

> +    description: 0 for I2S, 1 for S/PDIF
>  
>  required:
>    - compatible

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-synopsys-dw-dp-improvements-v8-0-ac1e6a75782f@collabora.com?part=20