Re: [PATCH 1/4] dt-bindings: media: qcom,sc7280-venus: Add dma-coherent property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch updates the YAML schema to require the 'dma-coherent' property but fails to update the device tree source, breaking DT validation and leaving the runtime bug unfixed.
--

--- Patch [1]: [PATCH 1/4] dt-bindings: media: qcom,sc7280-venus: Add dma-coherent property ---
commit 73ea504069776873329a245bdcc0241e9976a3c3
Author: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>

dt-bindings: media: qcom,sc7280-venus: Add dma-coherent property

This commit adds the dma-coherent property to the venus node binding schema
to address I/O coherency issues between the CPU and the video hardware.

> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> index 9725fcb761dc0..cc31f3ba7e7e0 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml

[ ... ]

> @@ -85,6 +87,7 @@ properties:
>  
>  required:
>    - compatible
> +  - dma-coherent

[Severity: Medium]
Will adding this to the required list break make dtbs_check for existing
device trees? 

Since the corresponding dts updates don't appear to be included in this patch,
the schema validation might fail because the dma-coherent property is missing
from the actual device tree source. 

Additionally, without updating the dts files used to build the DTB, will the
runtime data corruption issue described in the commit message persist because
the hardware configuration remains unchanged?

>    - power-domain-names
>    - iommus

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260801-iris-fixes-dma-pseq-fint-v1-0-aba0cb22f6ab@oss.qualcomm.com?part=1