Re: [PATCH v2 2/2] arm64: dts: rockchip: Add MangoPi M28K

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused pinctrl definition `wifi_wake_host_h` in device tree.
--

--- Patch [2]: [PATCH v2 2/2] arm64: dts: rockchip: Add MangoPi M28K ---
commit 5c35fa24023c282c8d840265113ad72db0aa147d
Author: Chukun Pan <amadeus@jmu.edu.cn>

arm64: dts: rockchip: Add MangoPi M28K

This commit adds device tree support for the MangoPi M28K development
board based on the Rockchip RK3528 SoC. It details various interfaces
such as USB, Ethernet, MMC, and regulators.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>

> diff --git a/arch/arm64/boot/dts/rockchip/rk3528-mangopi-m28k.dts b/arch/arm64/boot/dts/rockchip/rk3528-mangopi-m28k.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3528-mangopi-m28k.dts

[ ... ]

> +	wifi {
> +		wifi_reg_on_h: wifi-reg-on-h {
> +			rockchip,pins = <1 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		wifi_wake_host_h: wifi-wake-host-h {
> +			rockchip,pins = <1 RK_PA7 RK_FUNC_GPIO &pcfg_pull_down>;
> +		};

[Severity: Low]
Is this wifi_wake_host_h pinctrl intentionally left orphaned? 

It doesn't seem to be referenced by any device node in this file. It looks
like the AIC8800 WiFi module doesn't have a child node under &sdio0 (perhaps
due to lacking an upstream binding), which makes this pinctrl configuration
unused.

Would it be better to omit this pin configuration until the corresponding
WiFi node that uses it can be added to the device tree?

> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260801080018.3220034-1-amadeus@jmu.edu.cn?part=2