From: sashiko-bot@kernel.org
To: "Peter Robinson" <pbrobinson@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] arm64: dts: broadcom: bcm2712: adjust display status
Date: Sat, 01 Aug 2026 10:30:27 +0000 [thread overview]
Message-ID: <20260801103028.576A11F00AC4@smtp.kernel.org> (raw)
In-Reply-To: <20260801102000.551644-1-pbrobinson@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The top-level `vc4` DRM master node is disabled in the SoC `.dtsi` but not re-enabled in the Raspberry Pi 5 board `.dtsi`, completely breaking the display pipeline.
--
--- Patch [1]: [PATCH v2] arm64: dts: broadcom: bcm2712: adjust display status ---
commit b39f5cc8783fb43e147088a4ba5ca6fbab8b9d6c
Author: Peter Robinson <pbrobinson@gmail.com>
arm64: dts: broadcom: bcm2712: adjust display status
This commit disables the display IP by default in the BCM2712 SoC device
tree. It then re-enables the required display components in the Raspberry
Pi 5 board configuration to allow display output when desired.
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
> index b7a6bc34ae1ab..51c8533f31812 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
[ ... ]
> @@ -250,6 +273,14 @@ &pcie2 {
> status = "okay";
> };
>
> +&pixelvalve0 {
> + status = "okay";
> +};
> +
> +&pixelvalve1 {
> + status = "okay";
> +};
> +
> &v3d {
> clocks = <&firmware_clocks 5>;
> };
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> index 761c59d90ffc9..9b36ecd7bba54 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
[ ... ]
> @@ -667,6 +676,7 @@ v3d: gpu@1002000000 {
>
> vc4: gpu {
> compatible = "brcm,bcm2712-vc6";
> + status = "disabled";
> };
[Severity: High]
This disables the top-level vc4 DRM master node at the SoC level, but looking
at the overrides in bcm2712-rpi-5-b-base.dtsi, the corresponding &vc4
enablement seems to be missing.
Since the other display subcomponents are being re-enabled, does the missing
status = "okay" for the vc4 node completely prevent the display pipeline from
probing on the Raspberry Pi 5?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260801102000.551644-1-pbrobinson@gmail.com?part=1
prev parent reply other threads:[~2026-08-01 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 10:19 [PATCH v2] arm64: dts: broadcom: bcm2712: adjust display status Peter Robinson
2026-08-01 10:30 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801103028.576A11F00AC4@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=pbrobinson@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox