Re: [PATCH v3 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The device tree patch extends and references a non-existent label `pmk8550_vadc`, which will cause a fatal `dtc` compilation error.
- [Low] The patch uses undefined function-like macros (e.g., `ADC5_GEN3_AMUX3_GPIO_100K_PU(1)`), which will cause a syntax error during device tree compilation.
--

--- Patch [3]: [PATCH v3 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC ---
commit e7703c5dfab63d67ae0d89c48a05547baa5abd7f
Author: Aleksandrs Vinarskis <alex@vinarskis.com>

arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC

Describe embedded controller, its interrupt and required thermal zones.
Add EC's reset GPIO to reserved range, as triggering it during device
operation leads to unrecoverable and unusable state.

> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> index ce7b10ea89b6d..8d8d8014049bb 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
[ ... ]
> @@ -759,8 +759,32 @@ retimer_ss0_con_sbu_out: endpoint {
[ ... ]
> +	embedded-controller@3b {
> +		compatible = "dell,xps13-9345-ec";
> +		reg = <0x3b>;
> +
> +		interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
> +
> +		pinctrl-0 = <&ec_int_n_default>;
> +		pinctrl-names = "default";
> +
> +		io-channels = <&pmk8550_vadc ADC5_GEN3_AMUX3_GPIO_100K_PU(1)>,
[Severity: Low]
Does this file include the node definitions and bindings for pmk8550_vadc?

The pmk8550_vadc phandle does not appear to be defined in this file or its
typical includes, which will cause a dtc compilation error when the device
tree is built.

Additionally, is ADC5_GEN3_AMUX3_GPIO_100K_PU intended to be used as a
function-like macro taking an argument here?

The dt-bindings headers usually define this as a parameterless macro.
Supplying an argument like (1) will cause a preprocessor error during the
device tree compilation.

> +			      <&pmk8550_vadc ADC5_GEN3_AMUX4_GPIO_100K_PU(1)>,
[ ... ]
> @@ -1025,6 +1049,57 @@ rtmr0_1p8_reg_en: rtmr0-1p8-reg-en-state {
>  	};
>  };
>  
> +&pmk8550_vadc {
> +	sys_therm0: channel@14c {
> +		reg = <ADC5_GEN3_AMUX3_GPIO_100K_PU(1)>;
[Severity: Low]
Will appending to pmk8550_vadc work if the base node does not exist?

Similar to the io-channels property in the embedded-controller block,
attempting to append properties to an undefined pmk8550_vadc node will
result in a path not found error from the device tree compiler.

The reg assignment also uses the same function-like macro syntax which
will trigger a preprocessor failure.

> +		qcom,hw-settle-time = <200>;
> +		qcom,ratiometric;
> +		label = "lpddr5_therm";
> +	};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260801-dell-xps-9345-ec-v3-0-9f4bdb5a5dad@vinarskis.com?part=3