Re: [PATCH v2 2/4] pinctrl: qcom: Commonize pinctrl-sm8450 headers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Moving `enum sm8450_functions` to a shared header creates a brittle design highly susceptible to latent NULL pointer dereferences via array holes.
--

--- Patch [2]: [PATCH v2 2/4] pinctrl: qcom: Commonize pinctrl-sm8450 headers ---
commit f4cf6bf6634b4b995dec36c0bcb15b338f264b61
Author: Esteban Urrutia <esteuwu@proton.me>

pinctrl: qcom: Commonize pinctrl-sm8450 headers

This patch extracts common definitions, including pin groups and
functions, from pinctrl-sm8450.c into a new pinctrl-sm8450.h header.
This prepares the codebase for adding pinctrl support for SM8475, which
shares some of these definitions.

> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8450.h b/drivers/pinctrl/qcom/pinctrl-sm8450.h
> new file mode 100644
> index 0000000000000..7501c694db572
> --- /dev/null
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8450.h
[ ... ]
> +enum sm8450_functions {
> +	msm_mux_gpio,
> +	msm_mux_aon_cam,

[Severity: Medium]
Could moving this enum to a shared header introduce latent NULL pointer
dereferences via array holes?

If a future patch adds new functions for SM8475 in the middle of this shared
enum to maintain alphabetical order, it will change the enum values for SM8450.
This would leave holes (zero-initialized elements where .name is NULL) in the
designated initializers of the sm8450_functions array.

During probe, msm_pinctrl_setup_pm_reset() in pinctrl-msm.c iterates up to
the highest initialized index:

drivers/pinctrl/qcom/pinctrl-msm.c:msm_pinctrl_setup_pm_reset() {
	...
	for (i = 0; i < pctrl->soc->nfunctions; i++)
		if (!strcmp(func[i].name, "ps_hold")) {
	...
}

Because there is no NULL check for func[i].name, iterating over these
uninitialized array holes would crash.

> +	msm_mux_atest_char,
> +	msm_mux_atest_usb,
> +	msm_mux_audio_ref,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-sm8475-tlmm-v2-0-a93e1d1cb53b@proton.me?part=2