Devicetree
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: devicetree@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: wireless: brcm,bcm4329-fmac: add nvmem-consumer reference
Date: Sun,  2 Aug 2026 10:39:04 +0200	[thread overview]
Message-ID: <20260802083905.3819981-7-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <20260727225311.266596-1-rosenp@gmail.com>

On Mon, 27 Jul 2026 15:53:11 -0700, Rosen Penev <rosenp@gmail.com> wrote:
> The brcm,bcm4329-fmac binding has unevaluatedProperties set to false
> but does not allow nvmem-cells or nvmem-cell-names, which are used by
> DTS files (e.g. bcm4709-linksys-ea9200.dts) to supply MAC addresses.
>
> The driver already supports nvmem-based MAC address retrieval via
> of_get_mac_address(), so add the nvmem-consumer schema reference to
> document and allow these properties.
> ---
>  .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 +

The problem is real but I think the fix belongs in network-class.yaml rather
than the brcmfmac binding specifically. ethernet-controller.yaml already
defines nvmem-cells and nvmem-cell-names for wired NICs, but the wireless
binding hierarchy (wireless-controller.yaml -> network-class.yaml) is missing
them. Fixing it in network-class.yaml would cover all network nodes at once
instead of requiring each wireless driver to add the same reference
individually.

Regards,
Arend

  reply	other threads:[~2026-08-02  8:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 22:53 [PATCH] dt-bindings: net: wireless: brcm,bcm4329-fmac: add nvmem-consumer reference Rosen Penev
2026-08-02  8:39 ` Arend van Spriel [this message]
2026-08-10 17:30   ` Rob Herring
2026-08-10 19:21     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260802083905.3819981-7-arend.vanspriel@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox