Re: [PATCH v2 1/2] dt-bindings: i2c: Add Qualcomm I2C target controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `pinctrl-names` property will reject device trees that specify only the 'default' state because it is missing `minItems: 1`.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: i2c: Add Qualcomm I2C target controller ---
commit 3beba2240037bb340190bec9ca3218b520506b95
Author: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>

dt-bindings: i2c: Add Qualcomm I2C target controller

This commit adds a new device tree binding for the Qualcomm I2C target
controller, a dedicated IP distinct from existing master controllers. It
documents the required properties such as MMIO region, interrupts, clocks,
and interconnect paths, as well as optional pinctrl states.

> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-target.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-target.yaml
> new file mode 100644
> index 0000000000000..1e34e874cc4c3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-target.yaml

[ ... ]

> +  pinctrl-0: true
> +  pinctrl-1: true
> +
> +  pinctrl-names:
> +    items:
> +      - const: default
> +      - const: sleep

[Severity: Medium]
Will this strict list reject device trees that only specify the "default"
pinctrl state?

In dt-schema, an items list without an explicit minItems defaults to the
length of the list (2 in this case). This makes both "default" and "sleep"
mandatory whenever pinctrl-names is present. If it is legitimate for a
device to only define a single "default" pinctrl state, would it make sense
to add minItems: 1 here?

> +
> +required:
> +  - compatible
> +  - reg
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-i2c-qcom-slave-v2-0-27653118fa75@oss.qualcomm.com?part=1