Re: [PATCH v2 09/10] arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YT8521SC PHY node specifies 10G Energy Efficient Ethernet (EEE) errata properties (`eee-broken-10gt`, `eee-broken-10gkx4`, `eee-broken-10gkr`) despite being a Gigabit PHY.
--

--- Patch [9]: [PATCH v2 09/10] arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port ---
commit 08ee4bf87f62aaa593b62ffb0a37f8f8618a6a2a
Author: Coia Prant <coiaprant@gmail.com>

arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port

This commit enables the SGMII LAN port on the Ariaboard Photonicat,
adding the necessary XPCS, GMAC0, and MDIO0 nodes to make the Motorcomm
YT8521SC Gigabit Ethernet PHY functional.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> --- a/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
[ ... ]
> @@ -341,6 +352,39 @@ &i2s0_8ch {
>  	status = "okay";
>  };
>  
> +&mdio0 {
> +	sgmii_phy: ethernet-phy@3 {
> +		compatible = "ethernet-phy-id0000.011a";
> +		reg = <0x3>;
> +		max-speed = <1000>;
> +		eee-broken-10gt;
> +		eee-broken-10gkx4;
> +		eee-broken-10gkr;

[Severity: Low]
Are these 10G Energy Efficient Ethernet (EEE) errata properties intended for
this Gigabit PHY? Since max-speed is limited to 1000, these 10G-specific
properties appear to be inapplicable to this device.

> +		reset-assert-us = <20000>;
> +		reset-deassert-us = <100000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260801142244.679437-2-coiaprant@gmail.com?part=9