Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add DAC8163

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding defines `vrefin-supply` instead of the standard `vref-supply` property for the reference voltage.
--

--- Patch [1]: [PATCH v3 1/2] dt-bindings: iio: dac: Add DAC8163 ---
commit 027b4225a7fdd9879cb23634eb3bd5c71623e616
Author: Lukas Metz <lukas.metz@gmx.net>

dt-bindings: iio: dac: Add DAC8163

This commit adds a device tree binding for the Texas Instruments DAC8163
family of digital-to-analog converters. It covers devices such as DAC7562,
DAC7563, DAC8162, DAC8163, DAC8562, and DAC8563.

> diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml
> new file mode 100644
> index 0000000000000..ba4099c78e064
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml
[ ... ]
> +  ldac-gpios:
> +    description:
> +      Pin needs to be asserted permanently when updating the DAC synchronously.
> +    maxItems: 1
> +
> +  vrefin-supply:
> +    description:
> +      External reference voltage supply for scaling. When no vrefin-supply
> +      is present the internal voltage reference is used.

[Severity: Medium]
Is there a specific reason to define vrefin-supply here rather than the
standard vref-supply property?

The IIO naming convention typically uses vref-supply for reference voltages.
Diverging from this standard establishes an inconsistent device tree
interface and might complicate integration with generic subsystems.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-dac8163-work-v3-0-3ecc7bc66d0d@gmx.net?part=1