From: sashiko-bot@kernel.org
To: "Antony Kurniawan Soemardi" <linux@smankusors.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, lee@kernel.org,
robh@kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH v4 1/7] dt-bindings: mfd: syscon: add qcom,msm8960-sps-sic
Date: Sun, 02 Aug 2026 19:09:33 +0000 [thread overview]
Message-ID: <20260802190934.D83C61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260803-msm8960-wifi-v4-1-5ffa27aea39d@smankusors.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description starts with a lowercase letter, which violates the MFD subsystem guidelines for commit message capitalization.
--
--- Patch [1]: [PATCH v4 1/7] dt-bindings: mfd: syscon: add qcom,msm8960-sps-sic ---
commit 1cfd706762cb6881d8994b3ced230db695470176
Author: Antony Kurniawan Soemardi <linux@smankusors.com>
dt-bindings: mfd: syscon: add qcom,msm8960-sps-sic
This commit adds the compatible string for the Smart Peripheral System (SPS)
Interrupt Controller (SIC) on the Qualcomm MSM8960 SoC to the syscon
dt-bindings.
> dt-bindings: mfd: syscon: add qcom,msm8960-sps-sic
[Severity: Low]
This isn't a bug, but the description after the subsystem prefix is lowercase.
Could "add" be capitalized to "Add" to align with the MFD subsystem commit
message conventions?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-msm8960-wifi-v4-0-5ffa27aea39d@smankusors.com?part=1
next prev parent reply other threads:[~2026-08-02 19:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 19:03 [PATCH v4 0/7] ARM: qcom: msm8960: enable WCNSS (Bluetooth & Wi-Fi) Antony Kurniawan Soemardi via B4 Relay
2026-08-02 19:03 ` [PATCH v4 1/7] dt-bindings: mfd: syscon: add qcom,msm8960-sps-sic Antony Kurniawan Soemardi via B4 Relay
2026-08-02 19:09 ` sashiko-bot [this message]
2026-08-02 19:03 ` [PATCH v4 2/7] ARM: dts: qcom: msm8960: add RPM clock controller and fix USB clocks Antony Kurniawan Soemardi via B4 Relay
2026-08-02 19:21 ` sashiko-bot
2026-08-02 19:03 ` [PATCH v4 3/7] ARM: dts: qcom: msm8960: add SCM Antony Kurniawan Soemardi via B4 Relay
2026-08-02 19:22 ` sashiko-bot
2026-08-02 19:03 ` [PATCH v4 4/7] ARM: dts: qcom: msm8960: add SMEM & hwlock Antony Kurniawan Soemardi via B4 Relay
2026-08-02 19:08 ` sashiko-bot
2026-08-02 19:03 ` [PATCH v4 5/7] ARM: dts: qcom: msm8960: add SMSM & SPS Antony Kurniawan Soemardi via B4 Relay
2026-08-02 19:14 ` sashiko-bot
2026-08-02 19:03 ` [PATCH v4 6/7] ARM: dts: qcom: msm8960: add Riva Antony Kurniawan Soemardi via B4 Relay
2026-08-02 19:14 ` sashiko-bot
2026-08-02 19:03 ` [PATCH v4 7/7] ARM: dts: qcom: msm8960: huashan: enable Wi-Fi and Bluetooth Antony Kurniawan Soemardi via B4 Relay
2026-08-02 19:10 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802190934.D83C61F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux@smankusors.com \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox