Re: [PATCH 1/2] dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `items` constraint for 'BCM2712 based Boards' was incorrectly changed from a positional tuple list to a single `oneOf` object, breaking sequence and length validation. Additionally, the fallback constraint was misplaced.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping ---
commit bd4958062ba25329e2f64d01ee33b181fa435216
Author: Gregor Herburger <gregor.herburger@linutronix.de>

dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping

This commit updates the bcm2835 schema to add support for the Raspberry Pi 5
d0 stepping.

> diff --git a/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml b/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml
> index 2729a542c4f35..43729a887f846 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml
> @@ -25,8 +25,15 @@ properties:
>  
>        - description: BCM2712 based Boards
>          items:
> -          - enum:
> -              - raspberrypi,5-model-b
> +          oneOf:
> +            - enum:
> +                - raspberrypi,5-model-b
> +            - const: brcm,bcm2712

[Severity: Medium]
Does this change unintentionally break the strict tuple sequence validation for
the base BCM2712 boards?

By changing the items constraint from a positional tuple list to a single
oneOf object, the schema now applies this oneOf validation independently to
each element in the array. This allows device trees with incorrectly ordered
compatible strings, or those completely missing the fallback string, to
silently pass validation.

> +
> +      - description: BCM2712 based Boards d0 stepping
> +        items:
> +          - const: raspberrypi,5-model-b-d0
> +          - const: raspberrypi,5-model-b
>            - const: brcm,bcm2712

[Severity: Medium]
Is this the original fallback item from the BCM2712 block above?

It appears the original items list was split, causing the fallback
brcm,bcm2712 constant to be absorbed as the third element of the new d0
stepping items block, leaving the original BCM2712 based Boards block without
its fallback item.

>  
>        - description: BCM2835 based Boards

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-bcm2712-d-stepping-compatible-v1-0-401934357a44@linutronix.de?part=1