Re: [PATCH v9 21/22] dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Changing the `#sound-dai-cells` constraint to `const: 1` breaks `dtbs_check` for existing in-tree device trees.
--

--- Patch [21]: [PATCH v9 21/22] dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells ---
commit 843ed61619d9c1e4f037cc1104f1104af5111210
Author: Sebastian Reichel <sebastian.reichel@collabora.com>

dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells

This commit updates the device tree binding for the Rockchip DesignWare
DisplayPort controllers to support multiple DAI interfaces (I2S and S/PDIF).
It changes the #sound-dai-cells property constraint from 0 to 1 to allow
selecting the appropriate audio interface.

> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> index 2b0d9e23e9432..c4f8959dd65da 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml

[ ... ]

> @@ -83,7 +83,8 @@ properties:
>      maxItems: 1
>  
>    "#sound-dai-cells":
> -    const: 0
> +    const: 1
> +    description: 0 for I2S, 1 for S/PDIF

[Severity: Low]
Does this strict constraint change break dtbs_check for existing in-tree
device trees?

While the commit message notes this is an ABI break and that the mainline
rk3588 DTS will be fixed up separately, changing this directly to const: 1
causes validation warnings for existing boards.

Would it be better to temporarily allow both values using an enum: [0, 1]
during the transition to preserve CI and bisectability until the dts updates
are merged?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-synopsys-dw-dp-improvements-v9-0-2e6e46135312@collabora.com?part=21