Re: [PATCH v2 1/2] dt-bindings: nvmem: rockchip-efuse: add optional vqps supply

[Krzysztof Kozlowski <krzk@kernel.org>]

On Wed, Jul 29, 2026 at 02:28:55PM +0530, Hrushiraj Gandhi wrote:
> Add an optional vqps-supply property for the eFuse programming supply
> voltage (VQPS).
> 
> Per RK3399 TRM section 21.6.1, table 21-3, VQPS must be 0V during reads
> and 1.8V to 1.98V during A_PGM mode writes. The presence of this supply
> declares that the board hardware supports software-initiated eFuse
> programming and provides the requisite programming supply.
> 
> Signed-off-by: Hrushiraj Gandhi <hrushirajg23@gmail.com>
> ---
>  Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> index b80fd8d1ae5b..25f209fd881e 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> @@ -27,6 +27,11 @@ properties:
>        # Deprecated: old compatible value for rk3066a, rk3188 and rk3288
>        - rockchip,rockchip-efuse
>  
> +  vqps-supply:

Odd placement. reg always follows the compatible, see DTS coding style.
This is not even alphabetical. What is the logic?

Best regards,
Krzysztof