Re: [PATCH v7 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The applied diff is missing multiple changes explicitly claimed in the v5 and v6 changelogs, indicating an outdated or incorrectly rebased patch version was submitted.
--

--- Patch [1]: [PATCH v7 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60 ---
commit c8636e38cd00e42bd686aa15feae080b51b694e2
Author: Neo Chang <YLCHANG2@nuvoton.com>

ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60
    
Add device tree bindings documentation for the Nuvoton NAU83G60 audio
amplifier.

> Changes in v6:
> - Remove '|' from descriptions.
> - Add firmware-name in required.
> - Add "nuvoton,dsp-tx-slot-mapping" and "nuvoton,dsp-rx-slot-mapping" properties.
> 
> Changes in v5:
> - Remove the detailed datasheet information, keep only the valid I2C address enum
> - Simplify the firmware firmware-name items definition by removing the redundant
> minItems/maxItems and moving the channel descriptions directly into individual
> item entries.

[Severity: Medium]
It appears this patch doesn't include the updates mentioned in the v5 and v6
changelogs. Was an older or incorrectly rebased version of the patch sent?

> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml
> new file mode 100644
> index 0000000000000..2d19aedf1419a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml
[ ... ]
> +  firmware-name:
> +    minItems: 2
> +    maxItems: 2
> +    description:
> +      Assign firmware filenames for Left and Right DSP cores.

[Severity: Medium]
The v5 changelog states that the redundant minItems/maxItems were removed and
the channel descriptions were moved into individual item entries, but this block
still uses minItems and maxItems. Should this be updated to use an items list?

[ ... ]
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:

[Severity: Medium]
The v6 changelog explicitly mentions adding firmware-name to the required list.
Additionally, the nuvoton,dsp-tx-slot-mapping and nuvoton,dsp-rx-slot-mapping
properties mentioned in the v6 changelog are completely absent from the file.
Are these missing from the submitted patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804032951.1069901-1-YLCHANG2@nuvoton.com?part=1