Re: [PATCH v5 6/6] ARM: dts: qcom: Add Samsung Galaxy S4

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `muic` node contains invalid properties `safeout1-supply` and `safeout2-supply` which violate the device tree schema.
--

--- Patch [6]: [PATCH v5 6/6] ARM: dts: qcom: Add Samsung Galaxy S4 ---
commit 71d3822fee0022c24c538ba38400b342e55f2d78
Author: Alexandre MINETTE <contact@alex-min.fr>

ARM: dts: qcom: Add Samsung Galaxy S4

This commit adds initial device tree support for the Samsung Galaxy S4 (jflte).
It covers UART, USB peripheral mode, networking, front LED, and physical buttons.

> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts b/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts
> new file mode 100644
> index 0000000000000..75ae19af96e54
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts

[ ... ]

> @@ -115,14 +115,14 @@
> +			interrupts = <55 IRQ_TYPE_EDGE_FALLING>;
> +			pinctrl-0 = <&muic_int_default_state>;
> +			pinctrl-names = "default";
> +
> +			muic: muic {
> +				compatible = "maxim,max77693-muic";
> +				safeout1-supply = <&esafeout1_reg>;
> +				safeout2-supply = <&esafeout2_reg>;

[Severity: Low]
Are safeout1-supply and safeout2-supply supported by the maxim,max77693-muic
device tree binding?

The schema validation fails here because the binding does not define these
properties. This causes a validation failure during make dtbs_check.

> +			};
> +
> +			regulators {
> +				esafeout1_reg: ESAFEOUT1 {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-mainline-send-v1-sending-v5-0-149dd4372ac8@alex-min.fr?part=6