From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m15578.qiye.163.com (mail-m15578.qiye.163.com [101.71.155.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9194841D63F; Tue, 4 Aug 2026 08:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785831776; cv=none; b=Saw1bFnZfEja9Fshmifur9vGVmC1EMWdaKlqYB2lcXX6GcrUq6ehmB8d2erRt25i5CtxZ7NTHSmk6TrG2CsM3j1SjFNcznZfIUEbGC8W3gQAmEbeatTshKcJkSdNAIZxKUHuyzDIT6BybJd7HSgY5R6d0ba7TjrSUcsTsJGHBSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785831776; c=relaxed/simple; bh=+nriaTfGRGUuZolbvnrRUjWspWpQjWzPm0NAqhIjzyM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VCgZf6rCmUkOW6yq/dwJcf+A8kCF0DY6sD3dDzUYeiJ2ZdfBoiewQXVbOUDVyCyZ7XKn3AqaiFKGiSUHnWMNlzSz94cfsz5F2TNzoT0csXPjBFlyOO0SVvMqzJGaBrGK8JX2DbcudXJQsbaB/cm/7qiq991hn1xkxVKiJJVbh50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=QCGabk+Q; arc=none smtp.client-ip=101.71.155.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="QCGabk+Q" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 48b4fff07; Tue, 4 Aug 2026 16:17:32 +0800 (GMT+08:00) From: Damon Ding To: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Heiko Stuebner , Andy Yan Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Dmitry Baryshkov , Marek Szyprowski , Sebastian Reichel , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Damon Ding Subject: [PATCH v2 07/10] drm/bridge: analogix_dp: Use platform-specific HPD detection scheme Date: Tue, 4 Aug 2026 16:17:14 +0800 Message-Id: <20260804081717.741404-8-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260804081717.741404-1-damon.ding@rock-chips.com> References: <20260804081717.741404-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9fcbd96e8e03a8kunma7b8cbe762b0ca X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCQh5LVkgeGUxPT0pOGB5JSFYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSE pKQk1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=QCGabk+QwK5jAbSPr+yb8oB5ATcsAXCcuXxAghMo/OPvYwFSsoiw7Y9nekmGfrHRaxH1Lj+a6W17xjpZZj7jVMwmE6xKRAtk9Sa4JiJcSFhdG5IMeRmekQeI3a4vZcJO05lL56y4QdKn4fDe9V7WHONmlJ2AJ8OSMPlBPWcuWkc=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=VqqntTbLfre8Aozfj6SrJo9fJCRw3SHt2DOPzo6lH78=; h=date:mime-version:subject:message-id:from; Hotplug detection can be implemented either via HOTPLUG_CHG interrupt, or the combination of PLUG and HPD_LOST interrupts. For Rockchip platforms, configure HPD deglitch to 2ms and rely on HOTPLUG_CHG interrupt for hotplug events, which is verified as the optimal solution through engineering tests. Other platforms continue using PLUG + HPD_LOST pair. Adjust analogix_dp_config_interrupt() to apply platform-specific interrupt masking and deglitch settings. Update threaded irq handler to check corresponding interrupt flags according to platform type. Signed-off-by: Damon Ding --- Changes in v2: - Move ANALOGIX_DP_HPD_DEGLITCH_L/ANALOGIX_DP_HPD_DEGLITCH_H configs to analogix_dp_reset(). --- .../drm/bridge/analogix/analogix_dp_core.c | 9 ++++++-- .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 22 ++++++++++++++++--- 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 603abd940a7c..d207cc864bdc 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -717,13 +717,18 @@ static irqreturn_t analogix_dp_irq_thread(int irq, void *arg) { struct analogix_dp_device *dp = arg; u32 irq_type; + bool hpd_detected; irq_type = analogix_dp_get_irq_type(dp); if (irq_type) analogix_dp_clear_hotplug_interrupts(dp, irq_type); - if (irq_type & DP_IRQ_TYPE_HP_CABLE_IN || - irq_type & DP_IRQ_TYPE_HP_CABLE_OUT) { + if (!dp->hpd_gpiod && analogix_dp_is_rockchip(dp->plat_data->dev_type)) + hpd_detected = irq_type & DP_IRQ_TYPE_HP_CHANGE; + else + hpd_detected = (irq_type & DP_IRQ_TYPE_HP_CABLE_IN) || + (irq_type & DP_IRQ_TYPE_HP_CABLE_OUT); + if (hpd_detected) { dev_dbg(dp->dev, "Detected cable status changed!\n"); if (dp->drm_dev) drm_helper_hpd_irq_event(dp->drm_dev); diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c index 42463e18f392..fa8e2f104d6c 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c @@ -149,8 +149,13 @@ void analogix_dp_reset(struct analogix_dp_device *dp) writel(0x0, dp->reg_base + ANALOGIX_DP_PKT_SEND_CTL); writel(0x0, dp->reg_base + ANALOGIX_DP_HDCP_CTL); - writel(0x5e, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_L); - writel(0x1a, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_H); + if (analogix_dp_is_rockchip(dp->plat_data->dev_type)) { + writel(0x80, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_L); + writel(0xbb, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_H); + } else { + writel(0x5e, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_L); + writel(0x1a, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_H); + } writel(0x10, dp->reg_base + ANALOGIX_DP_LINK_DEBUG_CTL); @@ -177,7 +182,18 @@ void analogix_dp_config_interrupt(struct analogix_dp_device *dp) writel(0, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_2); writel(0, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_3); - analogix_dp_unmute_hpd_interrupt(dp, HPD_IRQ); + /* + * Either HOTPLUG_CHG interrupt or PLUG + HPD_LOST interrupt + * pair can be used to implement hotplug detection. + * + * On Rockchip platforms, configuring HPD deglitch to 2ms and + * using HOTPLUG_CHG interrupt for hotplug detection is proven + * as a better solution via engineering verification. + */ + if (analogix_dp_is_rockchip(dp->plat_data->dev_type)) + analogix_dp_unmute_hpd_interrupt(dp, DP_IRQ_TYPE_HP_CHANGE); + else + analogix_dp_unmute_hpd_interrupt(dp, HPD_IRQ); } void analogix_dp_mute_hpd_interrupt(struct analogix_dp_device *dp, u32 irq_type) -- 2.34.1