Re: [PATCH 05/10] dt-bindings: mfd: netronix,ntxec: Use generic power-controller schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a schema `$ref` to `/schemas/power/power-controller.yaml#`, which does not exist in the source tree, breaking schema validation.
--

--- Patch [5]: [PATCH 05/10] dt-bindings: mfd: netronix,ntxec: Use generic power-controller schema ---
commit c8d8d2474f8ae06d3e1689a3ed174b683577d897
Author: Peng Fan <peng.fan@nxp.com>

dt-bindings: mfd: netronix,ntxec: Use generic power-controller schema
    
This commit updates the netronix,ntxec binding to use the generic
power-controller schema by adding a reference to power-controller.yaml
and removing the locally defined system-power-controller property.

> diff --git a/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml
> index 37fbb953ea12e..2fa8b797c0dcf 100644
> --- a/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml
> +++ b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml
> @@ -13,6 +13,9 @@ description: |
>    This EC is found in e-book readers of multiple brands (e.g. Kobo, Tolino), and
>    is typically implemented as a TI MSP430 microcontroller.
>  
> +allOf:
> +  - $ref: /schemas/power/power-controller.yaml#

[Severity: Low]
Does power-controller.yaml exist in the kernel tree at this commit? 

It appears the generic power controller schema might still be a .txt file.
Referencing a non-existent YAML file causes the dt_binding_check target to
fail with an unresolved reference error. 

Additionally, because unevaluatedProperties is set to false in this binding,
failing to resolve the schema means the system-power-controller property
used in the example will be flagged as an invalid property.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-mfd-syspower-v1-0-a440783c2e78@nxp.com?part=5