Re: [PATCH v33 1/7] Documentation/firmware: add imx/se to other_interfaces

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The documentation includes a kernel-doc directive referencing a source file (`drivers/firmware/imx/se_ctrl.c`) that does not exist in the repository.
--

--- Patch [1]: [PATCH v33 1/7] Documentation/firmware: add imx/se to other_interfaces ---
commit 1eeded898bb09b76f97d9af8af8f731e994e4034
Author: Pankaj Gupta <pankaj.gupta@nxp.com>
Documentation/firmware: add imx/se to other_interfaces

This commit documents the i.MX SoC Service layer and C_DEV driver for hardware
secure enclaves. It outlines the architecture of messaging units (MU) dedicated
to specific enclaves, and explains the character device and service layer
interfaces.

> diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst
> index 06ac89adaafba..6c6fa9a0ba1df 100644
> --- a/Documentation/driver-api/firmware/other_interfaces.rst
> +++ b/Documentation/driver-api/firmware/other_interfaces.rst
[ ... ]
> +
> +When a user sends a command to the firmware, it registers its device_ctx
> +as waiter of a response from firmware.
> +
> +Enclave's Firmware owns the storage management over a Linux filesystem.
> +For this c_dev provisions a dedicated slave device called "receiver".
> +
> +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c
> +   :export:

[Severity: Low]
Does drivers/firmware/imx/se_ctrl.c exist in the tree at this point? 
It looks like running make htmldocs will emit a build warning or error because 
it cannot find this file to extract documentation from. Was this source file 
omitted from the patch series, or perhaps moved to a different directory?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260805-imx-se-if-v33-0-212e32ff0295@nxp.com?part=1