Re: [PATCH v3 1/4] dt-bindings: arm: qcom: fix PURWA/HAMOA IOT SOM compatibles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Renaming device tree compatible strings in the YAML schema without updating the corresponding device tree (.dts) files breaks schema validation and ABI.
--

--- Patch [1]: [PATCH v3 1/4] dt-bindings: arm: qcom: fix PURWA/HAMOA IOT SOM compatibles ---
commit 86746ff462577b3f827d2ec7f0eb293389e741dc
Author: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>

dt-bindings: arm: qcom: fix PURWA/HAMOA IOT SOM compatibles

This commit updates the compatible strings for the Hamoa and Purwa IoT
SOM platforms in the device tree bindings. It renames hamoa-iot-som to
iq-x7181-evk-som and purwa-iot-som to iq-x5121-evk-som to match the
official hardware documentation.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ff8a35df7862d..f244f547d5114 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1220,7 +1220,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,hamoa-iot-evk
> -          - const: qcom,hamoa-iot-som
> +          - const: qcom,iq-x7181-evk-som

[Severity: Critical]
Does replacing this compatible string break device tree schema validation for
existing boards?

Since the corresponding device tree files still use the old compatible
string, running make dtbs_check will report that qcom,hamoa-iot-som is
undefined. For example, in arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts:

	compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";

Also, does removing a deployed compatible string without retaining backwards
compatibility break the device tree ABI for existing bootloaders?

>            - const: qcom,x1e80100
>  
>        - items:

[ ... ]

> @@ -1235,7 +1235,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,purwa-iot-evk
> -          - const: qcom,purwa-iot-som
> +          - const: qcom,iq-x5121-evk-som

[Severity: Critical]
Will replacing this compatible string also break schema validation for the
Purwa IoT EVK board?

Similar to the Hamoa board, arch/arm64/boot/dts/qcom/purwa-iot-evk.dts still
uses the old string:

	compatible = "qcom,purwa-iot-evk", "qcom,purwa-iot-som", "qcom,x1p42100";

>            - const: qcom,x1p42100

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260805-hamoa-come-v3-v3-0-20463c43eae1@oss.qualcomm.com?part=1