From: Rob Herring <robh@kernel.org>
To: Taniya Das <taniya.das@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v9 06/10] dt-bindings: clock: qcom: Add support for CAMCC for Eliza
Date: Wed, 5 Aug 2026 09:26:46 -0500 [thread overview]
Message-ID: <20260805142646.GA795123-robh@kernel.org> (raw)
In-Reply-To: <20260804-eliza-mm-cc-v9-v9-6-39067760dc3c@oss.qualcomm.com>
On Tue, Aug 04, 2026 at 11:20:19PM +0530, Taniya Das wrote:
> Eliza camera clock controller is on CX and MX rails similar to Milos.
> Add compatible string for Eliza camera and camera BIST clock
> controller to the existing Milos camcc binding and add the
> dt-bindings header for Eliza.
>
> The camera clock controller provides power domains, so 'power-domain-cells'
You mean '#power-domain-cells'?
> must be present in the device tree node. Add this to required properties
> to enforce it in the binding schema.
The sashiko report seems valid to me. Should cambistmclkcc be a power
domain provider?
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
> .../bindings/clock/qcom,milos-camcc.yaml | 12 +-
> .../dt-bindings/clock/qcom,eliza-cambistmclkcc.h | 32 +++++
> include/dt-bindings/clock/qcom,eliza-camcc.h | 151 +++++++++++++++++++++
> 3 files changed, 193 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2026-08-05 14:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 17:50 [PATCH v9 00/10] Add support for Video, Camera, Graphics clock controllers on Eliza Taniya Das
2026-08-04 17:50 ` [PATCH v9 01/10] dt-bindings: clock: qcom,milos-camcc: Add missing power-domains support Taniya Das
2026-08-04 17:50 ` [PATCH v9 02/10] dt-bindings: clock: qcom,milos-videocc: " Taniya Das
2026-08-04 17:50 ` [PATCH v9 03/10] arm64: dts: qcom: milos: Add power-domains for camcc and videocc Taniya Das
2026-08-05 13:42 ` Abel Vesa
2026-08-04 17:50 ` [PATCH v9 04/10] dt-bindings: clock: qcom: Add video clock controller on Qualcomm Eliza SoC Taniya Das
2026-08-04 17:50 ` [PATCH v9 05/10] dt-bindings: clock: qcom: document the Eliza GPU Clock Controller Taniya Das
2026-08-04 17:50 ` [PATCH v9 06/10] dt-bindings: clock: qcom: Add support for CAMCC for Eliza Taniya Das
2026-08-04 18:29 ` sashiko-bot
2026-08-05 14:26 ` Rob Herring [this message]
2026-08-06 9:58 ` Taniya Das
2026-08-04 17:50 ` [PATCH v9 07/10] clk: qcom: videocc: Add video clock controller driver " Taniya Das
2026-08-04 17:50 ` [PATCH v9 08/10] clk: qcom: gpucc: Add GPU Clock Controller " Taniya Das
2026-08-05 13:40 ` Abel Vesa
2026-08-04 17:50 ` [PATCH v9 09/10] clk: qcom: camcc: Add support for camera clock controller " Taniya Das
2026-08-04 18:57 ` sashiko-bot
2026-08-04 17:50 ` [PATCH v9 10/10] arm64: dts: qcom: eliza: Add support for MM clock controllers Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805142646.GA795123-robh@kernel.org \
--to=robh@kernel.org \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=luca.weiss@fairphone.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox