Re: [PATCH v3 2/4] arm64: dts: ti: k3-am62a: Set MMC clock pins as OUTPUT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete fix for AM62A TRM MMC clock pin configuration, missing the phyCORE-AM62A SOM.
--

--- Patch [2]: [PATCH v3 2/4] arm64: dts: ti: k3-am62a: Set MMC clock pins as OUTPUT ---
commit b38183ead6a0951c2fe280be51beca049f7e3062
Author: Judith Mendez <jm@ti.com>

arm64: dts: ti: k3-am62a: Set MMC clock pins as OUTPUT

This commit updates the device tree for the AM62A7-SK board to configure the
MMC clock pins as output-only. This matches the TRM requirement to disable
the receiver.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 826fff38cfb77..9b120cd9b0c37 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -324,7 +324,7 @@ AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24) GPMC0_CSn3.I2C2_SDA */
>  	main_mmc0_pins_default: main-mmc0-default-pins {
>  		pinctrl-single,pins = <
>  			AM62AX_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */
> -			AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */
> +			AM62AX_IOPAD(0x218, PIN_OUTPUT, 0) /* (AB1) MMC0_CLK */

[Severity: High]
This is a pre-existing issue, but since you are fixing the TRM MMC clock pin
configuration for the AM62A, should we also fix the same violation on the
phyCORE-AM62A SOM?

In arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi in main_mmc0_pins_default:

        main_mmc0_pins_default: main-mmc0-default-pins {
                pinctrl-single,pins = <
                        AM62AX_IOPAD(0x220, PIN_INPUT_PULLUP, 0) /* (Y6) MMC0_CMD */
                        AM62AX_IOPAD(0x218, PIN_INPUT_PULLDOWN, 0) /* (AB7) MMC0_CLK */

The MMC0_CLK pin there retains the receiver-enabled PIN_INPUT_PULLDOWN setting
instead of being updated to PIN_OUTPUT as required by the TRM. Can this cause
signal integrity issues or MMC bus errors on that board?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260805225438.464184-1-jm@ti.com?part=2