Re: [PATCH v2 2/2] media: i2c: Add Sony IMX908 image sensor driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Setting V4L2 controls fails unconditionally with `-EINVAL` when `CONFIG_PM` is disabled, preventing streaming.
--

--- Patch [2]: [PATCH v2 2/2] media: i2c: Add Sony IMX908 image sensor driver ---
commit 92ff772dc92c29c7cb738f917f95440d0e6be72c
Author: Lachlan Michael <lachlan.michael@sony.com>
    
media: i2c: Add Sony IMX908 image sensor driver

This commit introduces a V4L2 sub-device driver for the Sony IMX908
8.39 megapixel CMOS image sensor. The driver supports RAW10 and RAW12
output formats and configures the MIPI CSI-2 interface.

> diff --git a/drivers/media/i2c/imx908.c b/drivers/media/i2c/imx908.c
> new file mode 100644
> --- /dev/null
> +++ b/drivers/media/i2c/imx908.c
[ ... ]
> @@ -0,0 +1,1501 @@
[ ... ]
> +static int imx908_set_ctrl(struct v4l2_ctrl *ctrl)
> +{
[ ... ]
> +	/* Hardware writes only when powered; cached ctrls applied on resume */
> +	ret = pm_runtime_get_if_in_use(imx->dev);
> +	if (ret <= 0)
> +		return ret;

[Severity: Medium]
When the kernel is compiled with CONFIG_PM=n, the inline stub for
pm_runtime_get_if_in_use() returns -EINVAL. Will this cause
imx908_set_ctrl() to unconditionally return -EINVAL in that configuration,
aborting __v4l2_ctrl_handler_setup() and preventing the stream from
starting?

Could this check be adjusted to handle the CONFIG_PM=n case by treating
-EINVAL as success, falling through to access the hardware since it would
be continuously powered in that configuration?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260806070934.21764-1-lachlan.michael@sony.com?part=2