Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v9 6/6] arm64: dts: qcom: Add device tree for Nord RRD board
Date: Thu, 06 Aug 2026 08:32:29 +0000	[thread overview]
Message-ID: <20260806083230.7D6241F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260806081554.448531-7-shengchao.guo@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The UFS reset GPIO index 181 requested in `nord-rrd.dts` is out of bounds with respect to the `gpio-ranges` defined in the SoC base DT.
--

--- Patch [6]: [PATCH v9 6/6] arm64: dts: qcom: Add device tree for Nord RRD board ---
commit 7d4cf30013817c741d9f964a48bd5626ffbd7ee5
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for Nord RRD board

This commit adds the initial device tree for the Qualcomm Dragonwing IQ10
RRD board. It enables various hardware components including the debug UART,
UFS storage, PMICs, I2C, and SPI.

> diff --git a/arch/arm64/boot/dts/qcom/nord-rrd.dts b/arch/arm64/boot/dts/qcom/nord-rrd.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/nord-rrd.dts

[ ... ]

> +&ufs_mem_hc {
> +	reset-gpios = <&tlmm 181 GPIO_ACTIVE_LOW>;

[Severity: High]
Is this GPIO index correct for the UFS reset? The requested index is 181,
but it appears the base SoC device tree (nord.dtsi) only maps 181 GPIOs
(indices 0 through 180) via its gpio-ranges property: 
gpio-ranges = <&tlmm 0 0 181>;

Will this cause the UFS driver to fail claiming its reset GPIO during probe,
preventing the primary storage from initializing during boot?

> +
> +	vcc-supply = <&vreg_l3i_2p5>;
> +	vcc-max-microamp = <1300000>;
> +	vccq-supply = <&vreg_l2i_1p2>;
> +	vccq-max-microamp = <1200000>;
> +
> +	status = "okay";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260806081554.448531-1-shengchao.guo@oss.qualcomm.com?part=6

      reply	other threads:[~2026-08-06  8:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06  8:15 [PATCH v9 0/6] Add initial device trees for Nord platform Shawn Guo
2026-08-06  8:15 ` [PATCH v9 1/6] arm64: dts: qcom: Add device tree for Nord SoC series Shawn Guo
2026-08-06  8:34   ` sashiko-bot
2026-08-06  8:15 ` [PATCH v9 2/6] arm64: dts: qcom: Add device tree for Nord GearVM variant Shawn Guo
2026-08-06  8:15 ` [PATCH v9 3/6] arm64: dts: qcom: Add device tree for Nord Embedded variant Shawn Guo
2026-08-06  8:15 ` [PATCH v9 4/6] dt-bindings: arm: qcom: Document Nord reference boards Shawn Guo
2026-08-06  8:15 ` [PATCH v9 5/6] arm64: dts: qcom: Add device tree for Nord Ride board Shawn Guo
2026-08-06  8:15 ` [PATCH v9 6/6] arm64: dts: qcom: Add device tree for Nord RRD board Shawn Guo
2026-08-06  8:32   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806083230.7D6241F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shengchao.guo@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox