Re: [PATCH v6 14/17] ARM: dts: microchip: sama7d65: add otpc node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The temperature calibration cell is defined but not linked to the ADC node, leaving the temperature sensor feature disabled.
- [Low] The patch includes the `microchip,sama7g5-otpc.h` header but does not use its macros.
--

--- Patch [14]: [PATCH v6 14/17] ARM: dts: microchip: sama7d65: add otpc node ---
commit 82cd7693b0c9ba34b6386bb02bb96ebcefa462e6
Author: Varshini Rajendran <varshini.rajendran@microchip.com>
Subject: ARM: dts: microchip: sama7d65: add otpc node

This commit adds the OTPC (One Time Programmable Controller) node to the
SAMA7D65 device tree. It also includes the nvmem layout and the definition
for the temperature calibration cell.

> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> index c35f27615bc49..aac2e22d96cb3 100644
> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> @@ -15,6 +15,7 @@
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/mfd/at91-usart.h>
> +#include <dt-bindings/nvmem/microchip,sama7g5-otpc.h>

[Severity: Low]
Is this dt-bindings header inclusion necessary? 

The macros defined in this header do not appear to be used, as the newly
added otpc node relies exclusively on direct hex values for its registers
rather than using the macros.

[ ... ]

> @@ -1111,6 +1112,21 @@ ddr3phy: ddr3phy@e3804000 {
>  			reg = <0xe3804000 0x1000>;
>  		};
>  
> +		otpc: efuse@e8c00000 {
> +			compatible = "microchip,sama7d65-otpc", "microchip,sama7g5-otpc", "syscon";
> +			reg = <0xe8c00000 0x100>;
> +
> +			nvmem-layout {
> +				compatible = "fixed-layout";
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +
> +				temperature_calib: calib@41435354 {
> +					reg = <0x41435354 0x2c>;	/* Temp calib data packet TAG */
> +				};

[Severity: Medium]
Should the existing ADC node be updated to reference this new temperature
calibration cell?

Without linking this new cell to the ADC node (adc@e1000000) using the
nvmem-cells and nvmem-cell-names properties, the ADC driver
at91-sama5d2_adc.c will return -ENOENT when attempting to call
nvmem_cell_get().

This causes the driver to silently skip registering the temperature channel
during probe, leaving the sensor disabled and this new calibration data
unreferenced.

> +			};
> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260806074024.531259-1-varshini.rajendran@microchip.com?part=14